Skip to content

fix(mosaic): align avatar menu action styles #10398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austincalvelage merged 2 commits into from
Oct 23, 2026
Merged

fix(mosaic): align avatar menu action styles #10398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
463ef4b
fix(mosaic): remove avatar menu icons
austincalvelage Oct 23, 2026
aa75058
fix(mosaic): style avatar removal as destructive
austincalvelage Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/plain-avatar-actions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
3 changes: 3 additions & 0 deletions ...file/user-profile-profile-section/__tests__/user-profile-profile-section.feature.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ describe('the user profile profile section', () => {

await openMenu(actor, await screen.findByRole('button', { name: 'Manage profile picture' }));
expect(screen.getByRole('menuitem', { name: 'Remove avatar' })).toBeInTheDocument();
expect(screen.getByRole('menuitem', { name: 'Change avatar' }).querySelector('svg')).toBeNull();
expect(screen.getByRole('menuitem', { name: 'Remove avatar' }).querySelector('svg')).toBeNull();
expect(screen.getByRole('menuitem', { name: 'Remove avatar' })).toHaveAttribute('data-color', 'negative');
});

it('says why an upload was refused', async () => {
Expand Down
6 changes: 2 additions & 4 deletions .../src/features/user-profile/user-profile-profile-section/user-profile-picture-row.view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { ActionMenu } from '../../../components/action-menu';
import { Avatar } from '../../../components/avatar';
import { Button } from '../../../components/button';
import { Section } from '../../../components/section';
import { Pen } from '../../../icons/glyphs/pen';
import { X } from '../../../icons/glyphs/x';
import { useMessages } from '../../../localization';
import { FileUpload } from '../../../primitives/file-upload';
import type { UserProfilePictureController } from './user-profile-picture.controller';
Expand Down Expand Up @@ -92,11 +90,11 @@ function ProfilePictureActions({
const actions: ActionMenuAction[] = [];

if (hasImage && canChange) {
actions.push({ label: m.picture.change, icon: Pen, onClick: openFilePicker });
actions.push({ label: m.picture.change, onClick: openFilePicker });
}

if (hasImage && onRemove) {
actions.push({ label: m.picture.remove, icon: X, onClick: onRemove });
actions.push({ label: m.picture.remove, color: 'negative', onClick: onRemove });
}

if (actions.length > 0) {
Expand Down
Loading