Skip to content

fix(mosaic): align avatar menu action styles - #10398

Merged
austincalvelage merged 2 commits into
mainfrom
austin/remove-avatar-menu-icons
Oct 23, 2026
Merged

austincalvelage merged 2 commits into
mainfrom
austin/remove-avatar-menu-icons

Conversation

@austincalvelage

@austincalvelage austincalvelage commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Description

Remove the icons from “Change avatar” and “Remove avatar”, and show “Remove avatar” in the red destructive style used by the other removal actions.

Before After
Before: avatar menu with icons and neutral remove action After: icon-free avatar menu with red remove action

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 23, 2026 8:24pm UTC
swingset Ready Ready Preview Oct 23, 2026 8:24pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 63847a9 and aa75058.

📒 Files selected for processing: 3
  • .changeset/plain-avatar-actions.md
  • packages/mosaic/src/features/user-profile/user-profile-profile-section/__tests__/user-profile-profile-section.feature.test.tsx
  • packages/mosaic/src/features/user-profile/user-profile-profile-section/user-profile-picture-row.view.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The profile picture menu no longer shows icons for “Change avatar” or “Remove avatar.” The “Remove avatar” action now uses the negative color. Tests verify these menu properties. An empty YAML frontmatter block was added to a changeset file.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • clerk/javascript#10375: Both changes set the negative color for the avatar remove menu action or its styling.

Suggested reviewers: alexcarpenter

Merge Risk: ⚪ Minimal · up to aa750

The avatar menu changes are narrowly scoped and covered by matching tests.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly describes the main change: aligning avatar menu action styles by removing icons and applying destructive styling to the remove action.
Description check Passed The description directly explains the avatar menu changes and identifies the intended destructive styling.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aa75058

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@austincalvelage austincalvelage changed the title fix(mosaic): remove avatar menu icons fix(mosaic): align avatar menu action styles Oct 23, 2026
@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10398

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10398

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10398

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10398

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10398

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10398

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10398

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10398

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10398

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10398

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10398

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10398

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10398

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10398

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10398

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10398

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10398

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10398

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10398

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10398

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10398

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10398

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10398

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10398

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10398

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10398

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10398

commit: aa75058

@austincalvelage
austincalvelage marked this pull request as ready for review October 23, 2026 20:32
@austincalvelage
austincalvelage enabled auto-merge (squash) October 23, 2026 20:32
@austincalvelage
austincalvelage merged commit c536061 into main Oct 23, 2026
164 of 170 checks passed
@austincalvelage
austincalvelage deleted the austin/remove-avatar-menu-icons branch October 23, 2026 21:56

This branch was successfully deployed

2 active deployments
Preview – swingset — aa75058b Deployed Oct 23, 2026 by vercel[bot]
Preview – clerk-js-sandbox — aa75058b Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants