Skip to content

feat(mosaic): add a lock icon to the password row in user profile - #10394

Open
prestonwebdev wants to merge 3 commits into
mainfrom
prestonwebdev/password-lock-icon-add
Open

prestonwebdev wants to merge 3 commits into
mainfrom
prestonwebdev/password-lock-icon-add

Conversation

@prestonwebdev

Copy link
Copy Markdown
Member

Description

Adds a lock icon in front of the password row in the Mosaic user profile Security panel, so it matches the passkey, 2-step verification and device rows. The icon reuses the shared UserProfileSecurityIcon with a new password name that maps to the existing Lock glyph. Includes an empty changeset.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: UI polish

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7f78d5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between b8faab8 and 7f78d5f.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between cf9c897 and f0435d5.

📒 Files selected for processing: 3
  • .changeset/lock-password-row.md
  • packages/mosaic/src/features/user-profile/user-profile-password-section/user-profile-password-row.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-security-icon.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The security icon component adds password to its accepted names and maps it to the Lock glyph. The password row imports and renders the icon. The changeset file contains empty YAML frontmatter with no package or release entries.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Possibly related PRs

  • clerk/javascript#10391: Changes the rendering style of UserProfileSecurityIcon, which this change uses in the password row.
  • clerk/javascript#10377: Updates UserProfileSecurityIcon and its styling, the same component extended here.

Suggested reviewers: austincalvelage

Merge Risk: ⚪ Minimal · up to b8faa

Merge Risk: ⚪ Minimal · up to b8faa

The requested password lock icon change appears safe to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description check Passed The description accurately explains the addition of the password lock icon, the shared icon mapping, and the changeset.
Title check Passed The title clearly and concisely describes the main change: adding a lock icon to the password row in the Mosaic user profile.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 23, 2026 8:21pm UTC
swingset Ready Ready Preview Oct 23, 2026 8:21pm UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10394

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10394

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10394

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10394

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10394

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10394

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10394

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10394

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10394

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10394

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10394

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10394

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10394

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10394

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10394

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10394

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10394

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10394

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10394

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10394

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10394

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10394

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10394

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10394

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10394

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10394

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10394

commit: 7f78d5f

This branch was successfully deployed

2 active deployments
Preview – swingset — 7f78d5f3 Deployed Oct 23, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 7f78d5f3 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants