fix(mosaic): use one filled IconFrame style for user profile icons by alexcarpenter · Pull Request #10391 · clerk/javascript

alexcarpenter · 2026-10-23T18:08:42Z

Description

User profile rows drew their icon tiles several different ways: passkeys used a filled IconFrame with no border, 2-step verification and Active devices styled Section.Media directly through an xstyle override, and connected accounts, Web3 wallets, payment methods and enterprise accounts used an unfilled, bordered IconFrame with logos at mixed sizes.

UserProfileSecurityIcon now renders an IconFrame inside Section.Media; the media override in user-profile-security-panel.styles.ts is removed.
Every user profile IconFrame is now filled with bordered={false}.
Connected account and Web3 wallet logos are 20px (were 24px), matching the payment method and enterprise account icons.
Connected account and Web3 wallet logos carry class="cl-provider-icon" and a kebab-cased data-provider (e.g. data-provider="okx-wallet"), so consumers can target a single provider's logo.
The Apple logo is nudged up 1px to sit optically centred in its frame.
A shared kebabCase util (src/utils/kebab-case.ts, adapted from es-toolkit, MIT) replaces the private helper in props.ts. It now also splits digits into their own words (web3 → web-3); no current data-* axis names are affected.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

vercel · 2026-10-23T18:08:50Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 23, 2026 8:44pm UTC
swingset	Ready	Preview	Oct 23, 2026 8:44pm UTC

changeset-bot · 2026-10-23T18:08:54Z

🦋 Changeset detected

Latest commit: 99afa9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-10-23T18:09:02Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: 46f142f
Latest commit, not reviewed: 99afa9f

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: carp/mosaic-security-icon-frame
File: .coderabbit.yaml
Commit: 46f142f
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 10984e1d-9fa7-4918-ab9d-151bc2a64a93

📥 Commits

Reviewing files that changed from the base of the PR and between 144b17e and 46f142f.

📒 Files selected for processing: 5

packages/mosaic/src/features/user-profile/user-profile-provider-media.styles.ts
packages/swingset/src/stories/fixtures/user-profile-connected-accounts.ts
packages/swingset/src/stories/fixtures/user-profile-web3-wallets.ts
packages/swingset/src/stories/user-profile-connected-accounts-section.stories.tsx
packages/swingset/src/stories/user-profile-web3-wallets-section.stories.tsx

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected)
clerk/cli (auto-detected)
clerk/clerk-ios (auto-detected)

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Provider icon identifiers now flow from connected-account and Web3 wallet data into UserProfileProviderMedia. The component uses the identifiers to derive theme props and applies an Apple-specific offset. Provider icon sizes changed. Provider, MFA, and security icons now use filled, unbordered frames. A shared kebabCase utility was added and is also used by themeProps.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

clerk/javascript#10377: Moves enterprise-account logos to UserProfileProviderMedia, whose icon-frame styling and provider theme data change here.
clerk/javascript#10394: Adds a password glyph to UserProfileSecurityIcon, whose rendering now uses a filled, unbordered IconFrame.
clerk/javascript#10376: Preserves Apple’s monochromeIcon value in connected-account fixtures; this change adds Apple-specific positioning in UserProfileProviderMedia.

Suggested reviewers: ephem

Merge Risk: ⚪ Minimal · up to 46f14

The profile icon changes are mergeable with no established user-facing or operational risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 5.26% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 22 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the main change: standardizing user profile icons with one filled, unbordered IconFrame style.
Description check		The description directly explains the icon styling changes, logo sizing updates, provider attributes, Apple alignment, and shared kebabCase utility.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T18:12:23Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10391

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10391

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10391

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10391

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10391

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10391

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10391

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10391

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10391

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10391

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10391

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10391

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10391

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10391

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10391

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10391

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10391

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10391

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10391

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10391

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10391

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10391

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10391

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10391

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10391

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10391

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10391

commit: 99afa9f

…ple logo

github-actions Bot added the mosaic label Oct 23, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 18:09

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 18:11

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 18:12

View deployment

vercel Bot deployed to Preview – swingset October 23, 2026 18:15

View deployment

alexcarpenter changed the title ~~fix(mosaic): render security row icons with a bordered IconFrame~~ fix(mosaic): use one filled IconFrame style for user profile icons Oct 23, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 18:17

View deployment

vercel Bot deployed to Preview – swingset October 23, 2026 18:20

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 18:28

View deployment

vercel Bot deployed to Preview – swingset October 23, 2026 18:30

View deployment

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 19:14

View deployment

vercel Bot deployed to Preview – swingset October 23, 2026 19:16

View deployment

coderabbitai Bot mentioned this pull request Oct 23, 2026

feat(mosaic): add a lock icon to the password row in user profile #10394

Open

1 of 9 tasks

alexcarpenter requested a review from austincalvelage October 23, 2026 20:05

alexcarpenter added 7 commits October 23, 2026 16:06

fix(mosaic): render security row icons with a bordered IconFrame

56fed42

fix(mosaic): fill provider and enterprise account icon frames

01421ce

fix(mosaic): size provider logos at 20px to match other provider icons

102d215

fix(mosaic): drop borders from user profile icon frames

70c2dcd

feat(mosaic): mark provider icons with data-provider and nudge the Ap…

8a8541a

…ple logo

refactor(mosaic): share a kebabCase util for data attributes

fd2de19

chore(swingset): pass iconId in provider fixtures

586d803

alexcarpenter force-pushed the carp/mosaic-security-icon-frame branch from 144b17e to 586d803 Compare October 23, 2026 20:10

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 20:11

View deployment

fix(mosaic): nudge the Apple logo with transform

46f142f

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 20:15

View deployment

austincalvelage approved these changes Oct 23, 2026

View reviewed changes

vercel Bot deployed to Preview – swingset October 23, 2026 20:18

View deployment

Merge branch 'main' into carp/mosaic-security-icon-frame

99afa9f

vercel Bot deployed to Preview – clerk-js-sandbox October 23, 2026 20:41

View deployment

vercel Bot deployed to Preview – swingset October 23, 2026 20:44

View deployment

alexcarpenter merged commit ab9557d into main Oct 23, 2026
56 checks passed

alexcarpenter deleted the carp/mosaic-security-icon-frame branch October 23, 2026 20:52

Navigation Menu

Repository navigation

fix(mosaic): use one filled IconFrame style for user profile icons - #10391

fix(mosaic): use one filled IconFrame style for user profile icons#10391
alexcarpenter merged 9 commits into
mainfrom
carp/mosaic-security-icon-frame

alexcarpenter commented Oct 23, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Reviews paused

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alexcarpenter commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercel Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexcarpenter commented Oct 23, 2026 •

edited

Loading

vercel Bot commented Oct 23, 2026 •

edited

Loading

changeset-bot Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 23, 2026 •

edited

Loading