Skip to content

test: allow pre-listing no-op warm-up services #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoewangg merged 1 commit into from
Oct 23, 2026
Merged

test: allow pre-listing no-op warm-up services #7481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions ...-tests/src/test/java/software/amazon/awssdk/warmup/allservices/AllServicesWarmUpTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,17 @@ class AllServicesWarmUpTest {

/**
* Services with no selectable warm-up operation (all operations are streaming or deprecated); warm-up only
* builds and closes the client.
* builds and closes the client. The list is maintained deliberately so that a service losing its warm-up
* operation is surfaced and tracked. An entry may be added before the model change that makes the service no-op
* ships, so listed services are not required to be no-op.
*/
private static final Set<String> KNOWN_NO_OP_SERVICES = new HashSet<>(Arrays.asList(
// All APIs are deprecated
"cloudhsm",
"finspacedata",
"iotthingsgraph",
"lexmodelbuilding",
"lookoutequipment",
"proton",

// All streaming operations
Expand Down Expand Up @@ -130,15 +133,11 @@ private void verifyWarmUp(SdkWarmUpProvider provider, String clientClassName) {

private void assertExpectedOperationRecorded(SdkWarmUpProvider provider, String clientClassName) {
if (KNOWN_NO_OP_SERVICES.contains(serviceName(provider))) {
assertThat(OperationRecordingInterceptor.operationNames())
.as("%s is listed in KNOWN_NO_OP_SERVICES but recorded an operation; remove the stale entry",
provider.getClass().getSimpleName())
.isEmpty();
} else {
assertThat(OperationRecordingInterceptor.operationNames())
.as("Warm-up of %s must invoke its selected warm-up operation", clientClassName)
.isNotEmpty();
return;
}
assertThat(OperationRecordingInterceptor.operationNames())
.as("Warm-up of %s must invoke its selected warm-up operation", clientClassName)
.isNotEmpty();
}

/**
Expand Down
Loading