Repository navigation
test: allow pre-listing no-op warm-up services - #7481
Merged
Merged
Conversation
Listed services no longer have to record nothing, so an entry can be added before the model change that removes a service's last warm-up operation ships. Add lookoutequipment to the list.
davidh44
approved these changes
Oct 23, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AllServicesWarmUpTestkeeps aKNOWN_NO_OP_SERVICESlist of services whose generated warm-up provider has no selectable operation: every operation is streaming or deprecated, so warm-up only builds and closes the client. The test checked the list in both directions. The services that are not listed had to record a warm-up operation, and listed services had to record none, or the test failed with "remove the stale entry".Because of the second check, the list could not be updated ahead of a model change. When a model update deprecates a service's remaining operations, the build fails until the service is listed. But listing it before the updated model is on the branch also fails, because the service still records an operation there.
Modifications
No production code or codegen changes.
Testing
test/warmup-testsmodule build: BUILD SUCCESS, 898 tests, 0 failures, 3 skipped. The skips are the existingKNOWN_WARMUP_FAILURE_SERVICESentry and client types some services do not generate.lookoutequipmentstill records an operation with its current model and passes under the relaxed rule.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License