Skip to content

chore: upgrade apify-client to v3 for e2e tests - #2304

Merged
vdusek merged 7 commits into
v2from
chore/apify-client-v3-e2e
Oct 13, 2026
Merged

vdusek merged 7 commits into
v2from
chore/apify-client-v3-e2e

Conversation

@vdusek

@vdusek vdusek commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Moves the e2e tests to apify-client v3, now that Python 3.10 is gone. The dev pin goes from <3.0.0 to <4.0.0, and the template e2e test uses the v3 API: model attributes instead of dict keys, and wait_duration=timedelta(...) instead of wait_secs.

Closes: #2303

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 13, 2026
@vdusek vdusek self-assigned this Oct 13, 2026
@vdusek vdusek linked an issue Oct 13, 2026 that may be closed by this pull request
@vdusek
vdusek requested a review from apify-factory October 13, 2026 11:31

@apify-factory apify-factory left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

@vdusek
vdusek marked this pull request as ready for review October 13, 2026 11:33
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2@fbf199c). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #2304   +/-   ##
=====================================
  Coverage      ?   94.11%           
=====================================
  Files         ?      183           
  Lines         ?    13565           
  Branches      ?        0           
=====================================
  Hits          ?    12767           
  Misses        ?      798           
  Partials      ?        0           
Flag Coverage Δ
unit 94.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek merged commit cac48e5 into v2 Oct 13, 2026
121 checks passed
@vdusek
vdusek deleted the chore/apify-client-v3-e2e branch October 13, 2026 11:38
vdusek added a commit that referenced this pull request Oct 16, 2026
Moves the e2e tests to apify-client v3, now that Python 3.10 is gone.
The dev pin goes from `<3.0.0` to `<4.0.0`, and the template e2e test
uses the v3 API: model attributes instead of dict keys, and
`wait_duration=timedelta(...)` instead of `wait_secs`.

Closes: #2303

*✍️ Drafted by Claude Code*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade apify-client to v3 in e2e tests

3 participants