Skip to content

GH-3289: Add basic CLI smoke tests - #3848

Open
zhangxinyao88 wants to merge 2 commits into
apache:masterfrom
zhangxinyao88:codex/parquet-3289-cli-behavior
Open

zhangxinyao88 wants to merge 2 commits into
apache:masterfrom
zhangxinyao88:codex/parquet-3289-cli-behavior

Conversation

@zhangxinyao88

@zhangxinyao88 zhangxinyao88 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Rationale for this change

Continue #3289 with basic CLI smoke coverage, using the helper added in #3843.

What changes are included in this PR?

Add two tests: version returns the expected version with a zero exit code, and an unknown command returns a nonzero exit code with the command name in the output. Neither test asserts help or error wording.

Are these changes tested?

CLI module tests: 72 passed, 2 skipped. Spotless and license checks passed.

Are there any user-facing changes?

No. Tests only.

@wgtmac

wgtmac commented Oct 11, 2026

Copy link
Copy Markdown
Member

I'm just wondering do we really need test cases like this?

@divjotarora

Copy link
Copy Markdown
Contributor

The changes themselves LGTM but I agree with @wgtmac's question on whether such tests are necessary. Can we write a more concise set of 1-2 tests to validate basic functionality instead? Also, is the exact wording from CLI output considered a stable API? If not, these tests are brittle and I'm not sure what exact contract they're testing.

@zhangxinyao88 zhangxinyao88 changed the title GH-3289: Test CLI help, version and error handling GH-3289: Add basic CLI smoke tests Oct 12, 2026
@zhangxinyao88

Copy link
Copy Markdown
Contributor Author

Can we write a more concise set of 1-2 tests to validate basic functionality instead?

Reduced to two smoke tests in 59c5aab: version output and unknown-command failure, without asserting help or error wording.

@zhangxinyao88

Copy link
Copy Markdown
Contributor Author

Reduced to two smoke tests in 59c5aab: version output and unknown-command failure, without asserting help or error wording.

Thinking about it more, these two tests may not justify a separate PR. I'd lean toward closing this and focusing on command options reaching the actual logic, as outlined in the tracker. Let me know your thoughts.

@divjotarora

Copy link
Copy Markdown
Contributor

Reduced to two smoke tests in 59c5aab: version output and unknown-command failure, without asserting help or error wording.

Thinking about it more, these two tests may not justify a separate PR. I'd lean toward closing this and focusing on command options reaching the actual logic, as outlined in the tracker. Let me know your thoughts.

I'll defer to @wgtmac here. IMO this doesn't need a separate PR. If we're just adding tests, my preference is a smaller set of bigger PRs rather than a large set of tiny ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants