Repository navigation
Snowflake: Add CREATE and DROP EXTERNAL VOLUME - #2475
Open
sabir-akhadov-localstack wants to merge 2 commits into
Open
sabir-akhadov-localstack wants to merge 2 commits into
sabir-akhadov-localstack wants to merge 2 commits into
Conversation
This was referenced Sep 1, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
from
October 15, 2026 10:20
f770b81 to
896abcd
Compare
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
==========================================
+ Coverage 81.16% 81.23% +0.07%
==========================================
Files 42 42
Lines 33769 33944 +175
Branches 33769 33944 +175
==========================================
+ Hits 27408 27575 +167
+ Misses 2797 2791 -6
- Partials 3564 3578 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's
CREATE EXTERNAL VOLUMEandDROP EXTERNAL VOLUMEdid not parse. Example that failed before:This adds
CREATE [OR REPLACE] EXTERNAL VOLUME [IF NOT EXISTS]andDROP EXTERNAL VOLUME(mirroring the merged CREATE/DROP WAREHOUSE, #2388). Each storage location is a parenthesized key-value option list parsed generically into the existingKeyValueOptions, so fields (including the nestedENCRYPTION = (...)list) may appear in any order, matching real Snowflake. Only an empty location is rejected; semantic checks such as the requiredSTORAGE_BASE_URLor duplicate fields are left to the consumer, in line with the parser's permissive stance. The trailingALLOW_WRITESandCOMMENTproperties are accepted in either order.DROP EXTERNAL VOLUMEreuses the genericStatement::Dropvia a newObjectType::ExternalVolume. All statements round-trip.See the Snowflake
CREATE EXTERNAL VOLUMEdocs.Replaces #2397, split into four PRs per review feedback — this one plus ALTER (#2474), DESC (#2472) and SHOW (#2473).