Skip to content

Snowflake: Add SHOW EXTERNAL VOLUMES - #2473

Open
sabir-akhadov-localstack wants to merge 2 commits into
apache:mainfrom
localstack:pr/09-show-external-volumes
Open

sabir-akhadov-localstack wants to merge 2 commits into
apache:mainfrom
localstack:pr/09-show-external-volumes

Conversation

@sabir-akhadov-localstack

@sabir-akhadov-localstack sabir-akhadov-localstack commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Snowflake's SHOW EXTERNAL VOLUMES did not parse:

SHOW EXTERNAL VOLUMES LIKE 'my_%';

This adds a ShowExternalVolumes statement to the Snowflake dialect, reusing the existing ShowStatementFilter for the optional LIKE clause. All statements round-trip.

See the Snowflake SHOW EXTERNAL VOLUMES docs.

Split out of #2397 per review feedback, alongside the CREATE/DROP (#2475), ALTER (#2474), and DESC (#2472) PRs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sabir-akhadov-localstack

Copy link
Copy Markdown
Contributor Author

Rebased on latest main. @iffyio @LucaCappelletti94 could you take a look when you have a moment? (One of the PRs split out of #2397.)

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

At this time we are rather overworked review wise, so I'll get to it when I'll get to it. I would appreciate if you could help out with reviewing other PRs, as it would accelerate our work and ultimately speed up the PR queue.

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.20%. Comparing base (5d653a2) to head (070d23f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ast/mod.rs 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2473      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.03%     
==========================================
  Files          42       42              
  Lines       33769    33891     +122     
  Branches    33769    33891     +122     
==========================================
+ Hits        27408    27520     +112     
+ Misses       2797     2796       -1     
- Partials     3564     3575      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebasing The PR has collisions with main and requires rebasing Snowflake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants