Repository navigation
CI: Bump actions to fix node 20 warnings - #466
Open
Ibn-Butt-Toota wants to merge 1 commit into
Open
Ibn-Butt-Toota wants to merge 1 commit into
Ibn-Butt-Toota wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at some of the actions and noticed there were warnings about some stuff using node 20, I looked into it and it was both actions/checkout@v4 and actions/cache@v4 .
I think the windows CI also calls something that uses node 20, but I'll just make a separate pr for that since I think the dependency hasn't been supported for a while... I'll put the relevant details in that PR, that way this one stays nice and simple.
Oh. I also just saw this: 657df0d I guess maybe it was intentional that this repo uses v4? Let me know / feel free to close this PR. (I guess I'm a little curious if these bumps are alright, but no worries if you don't feel like explaining.)