Repository navigation
CI: switch to maintained msvc setup action - #467
Open
Ibn-Butt-Toota wants to merge 1 commit into
Open
Ibn-Butt-Toota wants to merge 1 commit into
Ibn-Butt-Toota wants to merge 1 commit into
Conversation
The previous one last had an update ~2 years ago. Hopefully this one is more maintained...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous one last had an update ~2 years ago. Hopefully this one is more maintained. This is the followup to my last pr: #466, and this fixes the remaining node 20 warnings to my knowledge.
The old setup uses this: https://github.com/ilammy/msvc-dev-cmd but it's pretty outdated, with the last commit to main being 2 years ago and the last release being 3 years ago. Also there are even 2 prs about bumping the node version: ilammy/msvc-dev-cmd#106 and ilammy/msvc-dev-cmd#104
An alternative I was considering was to just move to a different setup, which I found here: https://github.com/TheMrMilchmann/setup-msvc-dev. It seems to be generally more up to date. I also happened to find a generally harmless typo while I was searching which led to this: TheMrMilchmann/setup-msvc-dev#527.
Anyways I figured this is probably better as a separate PR from #466 because I'm not sure what the policy is regarding what actions are OK to use, etc. Again feel free to let me know what you think or if this is alright.