Repository navigation
chore: Deprecate CommentMove.comment_ - #10600
Merged
Merged
Conversation
1 task done
gonfunko
changed the title
CommentMove.comment_.CommentMove.comment_
github-actions
Bot
added
PR: chore
gonfunko
force-pushed
the
deprecate-comment
branch
from
October 20, 2026 21:53
f134f58 to
29dcf51
Compare
mikeharv
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes part of #10219
Proposed Changes
This PR marks
CommentMove.comment_as deprecated. This field leaks a reference to a comment object, as events are long-lived in the undo stack. All other event types do not store the object they relate to, but rather its ID or a serialized representation. This field used to be for temporary storage, but became persistent a while ago. It will be removed in v14, but we should note it as deprecated in advance of that so that anybody relying on it can make adjustments now.Reason for Changes
This field is inconsistent with other event types and retains references to even deleted workspace comments as long as it remains in the undo stack.