Repository navigation
refactor!: Remove comment_ field from CommentMove - #10601
Merged
Merged
Conversation
gonfunko
changed the title
github-actions
Bot
added
breaking change
zspriggs
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10219
Proposed Changes
This PR removes the
CommentMove.comment_field in v14, which was marked as deprecated in v13 in #10600.Reason for Changes
This field is inconsistent with other event types and retains references to even deleted workspace comments as long as it remains in the undo stack.
Breaking Change
If you were using this field, you can instead use
Blockly.common.getWorkspaceById(moveEvent.workspaceId)?.getCommentById(moveEvent.commentId)to get a reference to the actual workspace comment object referenced by the event.