Skip to content

[wealth_dynamics] Retarget the JAX cross-reference after the lecture-jax rename - #1082

Merged
mmcky merged 1 commit into
mainfrom
fix-jax-wealth-dynamics-ref
Oct 9, 2026
Merged

mmcky merged 1 commit into
mainfrom
fix-jax-wealth-dynamics-ref

Conversation

@mmcky

@mmcky mmcky commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

QuantEcon/lecture-jax#353 renamed twelve lectures this morning, including wealth_dynamics to wealth_dynamics_jax, and lecture-jax's publish-2026oct09 release put the new names into the intersphinx inventory at 01:02 UTC. The {doc} cross-reference in wealth_dynamics.md still used the old name, so every build on this repo since then fails at the PDF step with "unknown document: 'jax:wealth_dynamics'" (warnings are errors there). #1081's preview failed this way. The publish-2026oct09 run here succeeded only because its PDF step ran before the lecture-jax site had actually redeployed, so the next publish would fail without this change.

This retargets the reference to jax:wealth_dynamics_jax. It is the only link from this repo into lecture-jax; the rename PR's search for cross-series links did not catch it because it is an intersphinx reference rather than a plain lecture name.

🤖 Generated with Claude Code

…jax rename

QuantEcon/lecture-jax#353 renamed its wealth_dynamics lecture to
wealth_dynamics_jax and the republished inventory no longer has the
old name, so the {doc} reference here fails and the PDF build, which
treats warnings as errors, fails with it on every branch.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 9, 2026 01:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The single-line retarget matches the confirmed lecture-jax rename (wealth_dynamics_jax.md) and the configured jax: intersphinx mapping, with no remaining stale references.

0 open findings

What changed in this PR

This PR fixes a broken intersphinx cross-reference in wealth_dynamics.md. After lecture-jax renamed wealth_dynamics to wealth_dynamics_jax (QuantEcon/lecture-jax#353) and redeployed, the old {doc} target jax:wealth_dynamics no longer resolves, causing PDF builds (where warnings are errors) to fail with "unknown document: 'jax:wealth_dynamics'". The change retargets the link to jax:wealth_dynamics_jax, restoring the "seealso" link to the JAX version of this lecture.

Changes:

  • Update the {doc} intersphinx reference from jax:wealth_dynamics to jax:wealth_dynamics_jax to match the renamed lecture-jax document.
File Description
lectures/​wealth_dynamics.md Retargets the JAX "seealso" cross-reference to the renamed wealth_dynamics_jax document so builds resolve the link.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mmcky
mmcky merged commit 8b9e5c8 into main Oct 9, 2026
3 checks passed
@mmcky
mmcky deleted the fix-jax-wealth-dynamics-ref branch October 9, 2026 01:41
@mmcky

mmcky commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python.zh-cn
Translation PR: QuantEcon/lecture-python.zh-cn#291
Files synced (1):

  • lectures/wealth_dynamics.md

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-1082--sunny-cactus-210e3e.netlify.app

Commit: 706b136

📚 Changed Lectures


Build Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants