Repository navigation
Conversation
Author
|
Added a second cross-build setting in commit 4086eb1: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Apple's typed-allocation Clang flags optional in the OpenAttributeGraph SwiftPM manifest. Native builds keep the current behavior by default. A Darwin cross build using a Clang without
-ftyped-memory-operationsor-ftyped-cxx-new-deletecan setOPENATTRIBUTEGRAPH_TYPED_MEMORY_OPERATIONS=0.Verification
clang: error: unknown argument: '-ftyped-memory-operations'and'-ftyped-cxx-new-delete'.0in both forks, the build passed those Clang errors and reached the next source/API gap in OpenSwiftUI_SPI (NSAttributedString initWithFormat:options:locale:arguments:).git diff --checkpassed.This PR changes only the opt-out path for cross toolchains; the default flags remain enabled for native Apple builds.