Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Clang's trailing-zero builtin when scanning a nonempty free-page map. This preserves the
std::countr_zeroresult for the nonzerounsigned long longreturned byto_ullong()and builds with older libc++ headers that lack the C++20 bit operation.Why
The target-aware arm64 macOS OpenSwiftUI dependency build compiles OpenAttributeGraph against Darling's current libc++ and failed in
table.cppbecausestd::countr_zerowas unavailable.Validation
OpenSwiftUItarget with local OpenAttributeGraph sources and Darling's libc++ headers.table.cppnow compiles and the build advances through the C++ sources to Swift errors inGraph.swift(NSDictionarybridging and optional string handling).free_pages_map.any()is true, so its zero input case is unreachable.Contributing
Reproduce with a C++20 compile of
table.cppagainst the older libc++ in Darling and the local Swift runtime headers selected through OpenAttributeGraph PR #242. AI-assisted changes should check the nonzero precondition and verify allocation scans still choose the least significant free bit.