Repository navigation
fix(playback): drop camera profile rejected by native interactive viewers (#2454) - #2455
Merged
Merged
Conversation
…wers (#2454) unisim-core 2.0.0 fails closed when Isaac native interactive viewers receive a non-default camera_kwargs profile, so interactive eval (e.g. sac/g1_walk_flat/isaacgym) crashed in bind_renderer before the viewer opened. run_playback_mode now mirrors the interactive debug-overlay degradation: warn, drop the camera profile, and retry. Record mode still forwards the profile and fails closed on rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ABEnv.run_playback_mode在 interactive 计划下捕获后端针对camera_kwargs的NotImplementedError,告警降级并不带相机配置重试播放(与既有 interactive debug-overlay 降级模式一致);record 模式行为不变,仍 fail closed。uv run eval --algo sac --task g1_walk_flat --sim isaacgym --render-mode interactive在bind_renderer抛错、viewer 无法打开。Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Remote CI route:
main: 当前 head CI 见本 PR checks(合并前确认通过)。Impact
Artifacts