Skip to content

fix(playback): drop camera profile rejected by native interactive viewers (#2454) - #2455

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-2454-isaac-interactive-camera
Oct 20, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-2454-isaac-interactive-camera

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • ABEnv.run_playback_mode 在 interactive 计划下捕获后端针对 camera_kwargs 的 NotImplementedError,告警降级并不带相机配置重试播放(与既有 interactive debug-overlay 降级模式一致);record 模式行为不变,仍 fail closed。
  • 修复 unisim-core 2.0.0 升级([C8] unisim 侧 API 命名规范化(跨仓轨道,API 命名审计) #2444)后的回归:Isaac 系原生交互 viewer 显式拒绝相机配置(unisim docs: reorganize multilingual documentation #113),导致 uv run eval --algo sac --task g1_walk_flat --sim isaacgym --render-mode interactive 在 bind_renderer 抛错、viewer 无法打开。
  • 用户面影响:isaacgym/isaacsim 交互 eval 恢复可用;会应用相机初始位姿的交互后端(genesis)行为不变;record 模式相机配置照常生效。

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/base/test_playback_mode.py -q                       # 3 passed(新增)
uv run pytest tests/base/test_playback_mode.py tests/scripts/test_train_scripts.py tests/visualization -q  # 62 passed
uv run ruff check src/unilab/base/base.py tests/base/test_playback_mode.py
uv run ruff format --check src/unilab/base/base.py tests/base/test_playback_mode.py
uv run mypy src/unilab/base/base.py
uv run pyright src/unilab/base/base.py
uv run eval --algo sac --task g1_walk_flat --sim isaacgym --render-mode interactive   # viewer 打开并播完,exit 0
uv run eval --algo sac --task g1_walk_flat --sim isaacgym --render-mode record training.play_steps=50  # play_video.mp4 正常写出
make test-all                                                            # exit 0

Remote CI route:

  • Base main: 当前 head CI 见本 PR checks(合并前确认通过)。

Impact

  • Backend impact: isaacgym / isaacsim(交互 eval 路径);其余后端无行为变化
  • Platform impact: Linux(macOS 无 Isaac 后端)
  • Training effect expected: no(仅播放/eval 路径)

Artifacts

  • W&B: 无
  • benchmark result: 无

…wers (#2454)

unisim-core 2.0.0 fails closed when Isaac native interactive viewers
receive a non-default camera_kwargs profile, so interactive eval
(e.g. sac/g1_walk_flat/isaacgym) crashed in bind_renderer before the
viewer opened. run_playback_mode now mirrors the interactive
debug-overlay degradation: warn, drop the camera profile, and retry.
Record mode still forwards the profile and fails closed on rejection.
@TATP-233
TATP-233 merged commit 6a9a0d0 into main Oct 20, 2026
12 checks passed
@TATP-233
TATP-233 deleted the fix/issue-2454-isaac-interactive-camera branch October 20, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant