Repository navigation
ci: run CI for stacked PRs whose base is a feature branch - #76
Merged
Merged
Conversation
The workflow listened only to pull_request -> main, so a stacked PR (base = feature branch) produced no CI run at all. That is exactly what happened to phases 2 and 3 of the migration: PR #74 and #75 were merged with a local clean-state run as the only evidence, and their status stayed unverifiable on GitHub. pull_request now also targets feat/**, exp/**, fix/**, chore/**. push stays main-only so one revision is never built twice. Job list unchanged (test, clean-state, manifest-parity, transport-equiv-e2e, docker-build); workflow yaml parses.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line change to the CI trigger:
pull_requestnow also fires for feature branches, not only formain.Why
The workflow listened only to
pull_request: branches: [main], so a stacked PR (base = feature branch) produced no CI run at all. That is exactly what happened to phases 2 and 3 of the migration:Fixing the code afterwards would have been the wrong order: this removes the reason the evidence had to be a caveat.
Scope
pull_request:[main, 'feat/**', 'exp/**', 'fix/**', 'chore/**']push: unchanged (mainonly), so a single revision is never built twice.Job list unchanged:
test,clean-state,manifest-parity,transport-equiv-e2e,docker-build. The workflow YAML parses and was verified locally before pushing.Cost
Stacked PRs now consume CI minutes (ubuntu + windows + clean-state ≈ 5 min). That is the intended trade: an unverified merge is worse than a slower one.