Skip to content

ci: run CI for stacked PRs whose base is a feature branch - #76

Merged
ManSio merged 1 commit into
mainfrom
ci/stacked-pr-runs
Oct 10, 2026
Merged

ManSio merged 1 commit into
mainfrom
ci/stacked-pr-runs

Conversation

@ManSio

@ManSio ManSio commented Oct 10, 2026

Copy link
Copy Markdown
Owner

What

One-line change to the CI trigger: pull_request now also fires for feature branches, not only for main.

Why

The workflow listened only to pull_request: branches: [main], so a stacked PR (base = feature branch) produced no CI run at all. That is exactly what happened to phases 2 and 3 of the migration:

Fixing the code afterwards would have been the wrong order: this removes the reason the evidence had to be a caveat.

Scope

  • pull_request: [main, 'feat/**', 'exp/**', 'fix/**', 'chore/**']
  • push: unchanged (main only), so a single revision is never built twice.

Job list unchanged: test, clean-state, manifest-parity, transport-equiv-e2e, docker-build. The workflow YAML parses and was verified locally before pushing.

Cost

Stacked PRs now consume CI minutes (ubuntu + windows + clean-state ≈ 5 min). That is the intended trade: an unverified merge is worse than a slower one.

The workflow listened only to pull_request -> main, so a stacked PR (base = feature branch) produced no CI run at all. That is exactly what happened to phases 2 and 3 of the migration: PR #74 and #75 were merged with a local clean-state run as the only evidence, and their status stayed unverifiable on GitHub.

pull_request now also targets feat/**, exp/**, fix/**, chore/**. push stays main-only so one revision is never built twice. Job list unchanged (test, clean-state, manifest-parity, transport-equiv-e2e, docker-build); workflow yaml parses.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8018ff88-05b6-4a21-b7ce-15e9368ca47e

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit 1612b53 into main Oct 10, 2026
13 checks passed
@ManSio
ManSio deleted the ci/stacked-pr-runs branch October 10, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant