Repository navigation
docs(diary): record the PR-pipeline incidents behind the merged stack - #77
Merged
Merged
Conversation
Three problems that had nothing to do with the code being green: - #73 turned CONFLICTING after #72 landed on main; the engine.py auto-merge was verified by hand (E24 fallback + MSCODEBASE_DENSE_OFF both survived). - The missing CI was a trigger bug, not a code bug: pull_request only matched main, so stacked PRs produced no run at all. Fixed in PR #76. - #58 sat CONFLICTING for 11 days with 1282 lines of code and 3 test files never reaching main; revived by a forward merge that keeps both sides of all three conflicts (2097 tests green, PR merged). Also records two near-misses worth keeping: the diff that looked like dead code was two hunks glued together (AST check before editing prevented a fix to a non-bug), and the portfolio purity guard caught three paraphrase collisions caused by the new corpus - reworded the text, never the test.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Diary record of the three problems behind the merged migration stack — none of which were code defects:
AGENT_DIARY.mdas a union automatically; theengine.pyauto-merge was read by hand and correctly kept both the E24 fast-fallbacktry/exceptand the newMSCODEBASE_DENSE_OFFcondition.pull_request: branches: [main]meant stacked PRs produced zero runs, so phases 2 and 3 shipped with a local clean-state run as their only evidence. Fixed in ci: run CI for stacked PRs whose base is a feature branch #76.Two near-misses also recorded
git diffhunk made it look like the P3 anchor call sat afterreturn pool(dead code). The diff had glued two hunks together; the file was correct. An AST check before editing prevented "fixing" a bug that did not exist.retrieval/score/results,vector/matching,produced/written). Fixed by rewording the experiment text, not the test — the 0/8 false-paraphrase baseline is preserved.Verification
verify_diary.py: gate-zero 2096 passed, 10 skipped, 34 entries, 0 failures. Ruff clean, all pre-commit hooks pass.