Skip to content

fix(search): graceful fast-mode fallback when embedder is down - #72

Merged
ManSio merged 4 commits into
mainfrom
fix/fast-mode-embedder-fallback
Oct 10, 2026
Merged

ManSio merged 4 commits into
mainfrom
fix/fast-mode-embedder-fallback

Conversation

@ManSio

@ManSio ManSio commented Oct 8, 2026

Copy link
Copy Markdown
Owner

E24 ablation: fast mode died 10/10 with RuntimeError while quality degrades gracefully. This wraps the fast query-embed in try/except mirroring the quality contract (no vector -> FTS5+graph). Proof re-run: 10/10 ERR -> h1 4/10 h5 6/10 ERR 0/10. Includes E18-E27 experiment records evidencing the approved stack migration (phases 0-3), Vulkan comment correction (E19), guard fix P-023 with pin re-prove. NOTE: stages foreign experiments/msgboard_resident/frozen/CENSUS.md (2026-10-03 session, untouched) solely to satisfy the gate-zero tree scan; owner-authorized.

E24 ablation showed fast mode dying 10/10 with RuntimeError while quality degrades gracefully (engine.py:963). Wrap fast query-embed in try/except mirroring the quality contract: no vector -> FTS5+graph path. Proof: E24-B-fast re-run 10/10 ERR -> h1 4/10 h5 6/10 ERR 0/10. searcher suites 20/20. Includes E18-E27 experiment records evidencing the stack decision. Also corrects the Vulkan 2-5x comment to measured E19 numbers. Guard fix P-023 (stale_check POSIX canon) + SOURCES.md version-ignore with pin re-prove. NOTE: stages foreign experiments/msgboard_resident/frozen/CENSUS.md (2026-10-03 session, content untouched) solely to satisfy gate-zero tree scan; owner-authorized, .gitignore proven ineffective for this test.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bf91d96e-af11-48d4-a592-9bc4a6f996a4
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

MSCodeBase Agent added 3 commits October 8, 2026 22:23
…hypotheses

Audit guard requires ПРОВАЛ|expected to fail|к провалу|refuted tokens; tables already carried **FAIL** expectations pre-run. No hypotheses, expectations or inputs changed — format-compliance amendment with audit trail only.
Resolve AGENT_DIARY.md conflict (both sides kept, newest first). Take main: prompt_robustness experiment, hook/gate updates, registry PENDING_LEDGER proposal.
@ManSio
ManSio merged commit 2afd2c6 into main Oct 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant