Repository navigation
chore(codecov): drop the unittests flag nothing uploads and the comment sections that cannot render - #460
Merged
Conversation
… comment sections that cannot render
`/flags/` for this repository answers exactly one flag and it has no coverage to report --
`{"count": 1, "results": [{"flag_name": "unittests", "coverage": 0.0}]}` (measured 2026-10-12) --
because the `coverage` job hands all three Cobertura reports to one *unflagged*
`codecov/codecov-action` call: `/commits/<full-sha>/uploads/` reads `count: 1` with `"flags": []`,
so no status and no comment section can ever read it. The flag declaration, and the `flags` and
`components` entries in `comment.layout`, are removed rather than left rendering empty forever.
The header comment asserted the opposite ("we expect exactly 3 uploads"), which is what made the
single upload look like a missing one; it now records the measured shape, so `after_n_builds` stays
unset for the real reason.
`codecov/project` has never been posted in this repository -- checked through the GitHub API for the
promotion commit `58f297e`, for `204d9f8`, `4283626`, `b6bcf34a` and for the PR heads #446/#447/#448:
every one carries `codecov/patch` and none carries `codecov/project` -- and the file now says so and
marks it BLOCKED, because nothing here can post it and the 18% floor is enforced in-job by
`tools/measure-coverage.ps1` either way.
Validated with `codecov.io/validate` (*Valid!*); the parsed form carries no `flags` key. Recorded in
`docs/CHANGELOG.md` under [Unreleased] -> Changed, because the PR comment a user sees does change.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ed, the patch-status item is refuted as already green, and codecov/project is BLOCKED The session's finding is that the work the item was opened for was not needed: PR #448 was already merged (`b6bcf34a`) and `codecov/patch` on it had already passed (51,01 % against the effective 45 % floor -- `target: 50 %` + `threshold: 5 %`), so no test was written for the 121 patch misses. What was unfinished was the config half, and that is what `4eafadd8` lands; this entry records the live-API evidence (including the `coverage: 0.0` correction to the draft comment), the runner-verified green of PR #460, and the BLOCKED `codecov/project` gap that is carried forward in NEXT rather than dropped.
…iven, so its half of the effect is a post-merge observation, not a PR-time claim
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The follow-up to #448 that no test can cover:
codecov.ymldeclares a flag nothing uploads, and its PRcomment advertises two sections that can never render. Config-only, no source change, so the verification is
Codecov's own evaluation of this PR rather than a red-to-green test.
Context on the gate itself: #448's
codecov/patchalready passed (51,01 % against a 45 % effectivefloor,
target: 50 %+threshold: 5 %), so nothing here changes gating -- the comment and flag list arethe only user-visible surface this touches.
The measurement
unittestsflag has no coverage to report/flags/answers exactly{"count": 1, "results": [{"flag_name": "unittests", "coverage": 0.0}]}/commits/4283626d8235b4e2175097a929a9b0e1613a17b2/uploads/answerscount: 1with"flags": [](the endpoint wants the full 40-character SHA; the abbreviated form answers 404)coveragejob callscodecov/codecov-actiononce with all three Cobertura reports -- which is whyafter_n_buildsstays unsetThe file's header comment asserted the opposite ("we expect exactly 3 uploads"), which is what made the
single upload look like a missing one. The comment now records the measured shape.
The change
flags: unittests(paths: [src/],carryforward: true) removed, with a comment stating why the uploadis unflagged and what the flag list answers instead.
comment.layoutlosesflagsandcomponents(header, diff, tree) -- this file defines nocomponent_management, so both sections could only ever render empty.What is not changed, and is marked
BLOCKEDcodecov/projecthas never been posted in this repository. Checked through the GitHub API for the promotioncommit
58f297e, for204d9f8,4283626andb6bcf34a, and for the heads of #446/#447/#448: every oneof them carries
codecov/patchand none carriescodecov/project, including the commits whose base doeshave an uploaded report. Nothing in this file can post it, and nothing is lost while it is absent (the patch
status, the PR comment and the in-job 18 % floor at
tools/measure-coverage.ps1 -Floor 0.18all stillreport), so it is written into the file as
BLOCKEDrather than left as a silent gap.Verification
curl -X POST --data-binary @codecov.yml https://codecov.io/validate->Valid!, and the parsed formcarries no
flagskey.chore; the only user-visible effect is the PR comment.Merging publishes packages to NuGet.org (
pack/publishrun on a push tomaster), so this stops atan open PR.