Repository navigation
docs(codecov): correct the post-merge flag-list prediction -- the registry entry outlives the declaration - #461
Open
MPCoreDeveloper wants to merge 1 commit into
Open
MPCoreDeveloper wants to merge 1 commit into
MPCoreDeveloper wants to merge 1 commit into
Conversation
…istry entry outlives the declaration PR #460 landed on `master` as `b4b9a70d` (owner instruction, 2026-10-13T04:01:14Z), and the session-86 addendum predicted that the repository-level `/flags/` list would drop its `unittests` entry once `master` carried the change. The first post-merge measurement refutes that: the merge commit's own coverage upload was processed at 04:04:43Z by a tree that declares no `flags:` section at all (`count: 1`, `"flags": []`, 537 files / 58 907 lines), and at 04:13:47Z `/flags/` still answers `{"count": 1, "results": [{"flag_name": "unittests", "coverage": 0.0}]}`, with `/flags/unittests/` live at HTTP 200. So that list is a repository-level registry Codecov keeps -- driven neither by the current contents of codecov.yml nor by the head upload's flags -- and no directive in the file deletes an entry from it. The correction is recorded where the claim was made (addendum 2 in docs/performance/WORKLOG.md), in docs/CHANGELOG.md, and in the `flags` comment of codecov.yml, which now carries the measurement instead of the inference so the next session can re-check rather than re-infer. The lingering entry is BLOCKED as an outside-repository dashboard action, the same class as `codecov/project`; nothing is fixed by weakening anything (no status, floor or flag semantics change). codecov.io/validate answers `Valid!` and the parsed form still carries no `flags` key.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Follow-up to #460, which the owner landed on
masterasb4b9a70d(2026-10-13T04:01:14Z). The session-86 addendum predicted that the repository-level/flags/list would drop itsunittestsentry oncemastercarried the config change. The first post-merge measurement refutes that, so this PR corrects the record instead of leaving the prediction standing.The evidence
/commits/b4b9a70dfd6bb453ff7bcd03a00294be38c0d362/uploads/count: 1,state: merged,"flags": [], 537 files / 58 907 lines, created 2026-10-13 04:04:43Z (after the 04:01:14Z merge)/flags/at 04:13:47Z{"count": 1, "results": [{"flag_name": "unittests", "coverage": 0.0}]}— unchanged/flags/unittests/HTTP 200, carrying acoveragelink — a live registry entity, not a 404codecov.ymlonb4b9a70dflags:key at allThe upload was processed by a tree that declares no flag, and the flag list did not move. So the list is a repository-level registry Codecov keeps — not a view of the current file's contents and not a view of the head upload's flags — and no directive in
codecov.ymldeletes an entry from it.What changed
codecov.yml— theflagscomment now carries the measurement above (merge SHA, upload timestamp, both endpoint answers) in place of an inference, so the next reader re-checks rather than re-infers.docs/CHANGELOG.md— the[Unreleased] → Changedentry states that the registry entry outlives the declaration.docs/performance/WORKLOG.md— session 86, addendum 2, appended at EOF: the merge (branch left in place), master's green pipeline includingPublish to NuGet.org, the refutation with its evidence, and theNEXT:line.Deliberately not changed
tools/measure-coverage.ps1 -Floor 0.18, and no test was loosened.unittestsregistry entry — deleting it is a Codecov dashboard action, the same class as the long-standingcodecov/projectitem. It costs nothing (no upload carries the flag, no status reads it) and it is recorded incodecov.yml, never dropped.Verified
codecov.io/validate→Valid!, with the parsed form still carrying noflagskey.master's pipeline onb4b9a70d(CI/CD Pipelinerun38344447898):Build and Testsuccess on windows/ubuntu/macos,Coverage (net11.0)success,Pack NuGet Packagessuccess,Publish to NuGet.orgsuccess.