Repository navigation
Show immediate feedback while dismissing Console rows - #1259
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1258.
Updates the manual, generated manual page, and hand-written Console descriptions.
Evidence
node --test --test-name-pattern='Dismiss and Undo show pending feedback' console/tests/inbox.test.cjsfailed waiting for pending feedback (2000 ms timeout).After:
node --test --test-name-pattern='Dismiss' console/tests/inbox.test.cjspasses all 3 Dismissal tests, including delayed Dismiss/Undo, live refresh, duplicate submit, and failure/retry cases.cargo build --lockedpasses.npm test --prefix console: 78 passed. Site browser/generation checks: 49 passed./usr/bin/time -p scripts/affected-tests mainpassed, including 49 site checks and the selectedcargo nextest run: 2606 passed, 58 skipped (8 slow). Total wall time: 1633.71 seconds (27m 14s), including site checks and compilation. Rust test compilation took 2m 24s; nextest reported 1364.833 seconds of test execution.5345d81eccc578fe0c12e8236caeed8096ffc682, including Linux Rust, Console, site, macOS gate, and release builds: CI run.Test seams
Review coverage
Independent Standards and Spec reviews used
git diff main...HEAD, withmainfixed atfa2d80dcde66ad964b8c883f81d1f3d540358206. Both read all 7 changed files, including the generatedsite/docs/index.htmlhunk. No generated-output exclusions. Unread changed files: none on either axis. Standards: one optional low-priority test-duplication heuristic; no hard violations. Spec: no findings.Unaddressed findings
Standards
pageForhelper owns shared browser-context cleanup. The repeated blocks contain no product logic. Evidence: pending-request setup, failure/retry setup, and shared page helper. The reviewer explicitly accepts local setup for readability. No behavioral defect was alleged; no Spec or Day shift decision is deferred.Spec
None.
Security
None. Reviewed
git diff fa2d80dcde66ad964b8c883f81d1f3d540358206...HEAD(client pending-dismissal feedback insrc/console/assets/console.jsplus tests/docs) with supporting code (src/console/dismiss.rs,src/console/auth.rs,src/console/peek.html). No introduced finding: server error text and pending messages render only viatextContent(no HTML sink inconsole.js); the POST still sends the full form including the CSRF field and middleware still enforces it (src/console/auth.rs); CSP keepsframe-ancestors 'none'; the new duplicate-submit guard only removes a double-POST race. Local sink check passes; no PoC failure to fix, so no code change from this review.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the commit to restore the previous browser feedback; durable Dismissals and server actions use the existing implementation.
Blast Radius: Console
Command-details Dismiss/Undo feedback and browser tests, plus documentation.
Built with codex · gpt-6.1-sol · xhigh