[JacobStephens2]

Summary

One scoped Inbox evaluation captures Stop requests and Dismissals, derives row decisions once, and supplies all five consumers. GitHub refresh constructs its authoritative evaluation after reloading the kept answer under the lock.

Snapshot.evaluate_inbox(days, kept)
├── into_rows / into_target → status, Console, Dismissal
├── refresh_work           → subjects, Finding subjects, History freezes
└── next_change            → watch deadlines

History visibility is applied before collapse for both rows and Dismissal targets. Explicit History Undo remains available.

Closes #1250

Evidence

• Before: cargo test --test dismiss undo_visible_row_leaves_hidden_history_dismissal_alone -- --exact failed: Undo removed a hidden History row's Dismissal.
  After: the same regression passes and is retained, with its final assertions checking public status --all --json output.
• Joint deterministic evaluation tests cover captured Stop/Dismissal edits, History filtering and exact cutoffs, shared-URL current/History rows, unresolved and legacy freezes, and independent Finding/Dismissal precedence. All 26 reading tests pass.
• Status, Dismissal and Console HTTP/event regressions pass. cargo check --all-targets and cargo clippy --all-targets -- -D warnings pass.
• node --test --test-name-pattern='Dismiss|selection|selected|push morphs' console/tests/inbox.test.cjs: 6 passed, including Dismiss/Undo and selection across pushes.
• /usr/bin/time -p scripts/affected-tests main passed on final head 530f200: full Rust suite via the documented cargo test fallback, 1562.21 seconds wall time, including the incremental compilation check (0.34 seconds).

Test seams

• Snapshot's scoped Inbox evaluation: consuming row/target projections, read-only refresh work and next deadline, using native temporary files and fixed time.
• Existing CLI status/Dismissal and Console HTTP/event/browser interfaces.

Review

• Standards: two findings addressed: name the remote-read predicate precisely and assert the Undo result through public status output.
• Spec: one finding reproduced and fixed: keep hidden History members out of a visible row's Undo membership.
• Both reviewers read all 10 changed files. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Internal refactor with no stored-format or domain-definition changes.

Blast Radius: Inbox

Shared row grouping, GitHub refresh planning, watch deadlines and Dismissal targeting for CLI and Console.

Built with codex · gpt-6.1-sol · xhigh