Repository navigation
feat: use SiteMappingDescription from EssentialCSharp.Shared.Models - #1560
Merged
Merged
Conversation
Bump the tooling packages to 1.1.1.19570 and replace the private ChapterDescription record with the shared SiteMappingDescription type that the tooling serializes.
BenjaminMichaelis
deleted the
feat/use-shared-site-mapping-description
branch
October 24, 2026 01:10
This was referenced Oct 24, 2026
BenjaminMichaelis
added a commit
that referenced
this pull request
Oct 24, 2026
## Summary - Bumps `ToolingPackagesVersion` 1.1.1.19570 -> 1.1.1.19573. - 19570's content package shipped `sitemap.descriptions.json` with the old single-string `"Key"` format, which `SiteMappingDescription` (used by `ChapterDescriptionService` since #1560) cannot deserialize, so dev returned 500. 19573 is built from IntelliTect-dev/EssentialCSharp.Tooling#2606, which converts the file to the `Keys` array format and adds a tooling test that reads the real file. ## Test plan - [x] `dotnet build EssentialCSharp.Web.slnx` - [x] `EssentialCSharp.Web.Tests`: 190 passed - [x] At the tooling commit 19573 was built from (1f77290e), `sitemap.descriptions.json` has 589 `"Keys"` entries and no `"Key"` entries - [ ] Not checked locally: the restored ContentFeedNuget package contents. Please confirm dev serves pages after deploy. Related: #1561 (Key/Keys compatibility and CI check against the real package content) is still open and no longer needed to fix dev once this is deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolingPackagesVersion1.1.1.19562 -> 1.1.1.19570, which addsSiteMappingDescription(IntelliTect-dev/EssentialCSharp.Tooling#2605).ChapterDescriptionServicenow deserializessitemap.descriptions.jsoninto the sharedSiteMappingDescriptioninstead of a privateChapterDescriptionrecord, so the tooling and web app share one type, likeSiteMapping.Test plan
dotnet build EssentialCSharp.Web.slnxChapterDescriptionServiceTests(2 pass)