Repository navigation
chore: bump tooling packages to 1.1.1.19573 - #1562
Merged
Merged
Conversation
Picks up sitemap.descriptions.json in the Keys array format that SiteMappingDescription deserializes (IntelliTect-dev/EssentialCSharp.Tooling#2606).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolingPackagesVersion1.1.1.19570 -> 1.1.1.19573.sitemap.descriptions.jsonwith the old single-string"Key"format, whichSiteMappingDescription(used byChapterDescriptionServicesince feat: use SiteMappingDescription from EssentialCSharp.Shared.Models #1560) cannot deserialize, so dev returned 500. 19573 is built from IntelliTect-dev/EssentialCSharp.Tooling#2606, which converts the file to theKeysarray format and adds a tooling test that reads the real file.Test plan
dotnet build EssentialCSharp.Web.slnxEssentialCSharp.Web.Tests: 190 passedsitemap.descriptions.jsonhas 589"Keys"entries and no"Key"entriesRelated: #1561 (Key/Keys compatibility and CI check against the real package content) is still open and no longer needed to fix dev once this is deployed.