Repository navigation
[Backend] Refactor in Rust - #656
Draft
JavierRibaldelRio wants to merge 90 commits into
Draft
JavierRibaldelRio wants to merge 90 commits into
JavierRibaldelRio wants to merge 90 commits into
Conversation
Implements the ADJv3 domain types for software-core: - measurement: add numeric id + alias (per ADJv3 §2), display_units, and a protections list; drop the now-superseded safe/warning ranges - protections: ProtectionKind (Above/Below/Equal/NotEqual/Range), Severity, Protection — data-carrying variants instead of a flat value array + range flag, so mismatched bound counts can't compile - packet: Packet and its variants (Data, Order, Protection, Message), ShortTimestamp with the sub-second field, MessageLevel — protections and messages are now unrelated wire formats, so state orders and the old message-as-protection-kind are gone - board: PacketKind, PacketDef, Board, PodData - fix 9 broken rustdoc intra-doc links, restore missing tests on measurement.rs, remove dead code, run cargo fmt DataPacket/OrderPacket values are positional (Vec<Value>, matched by index against PacketDef.measurements), not tagged per-value with an id. Open questions for a follow-up: whether to drop the now-unused Range type, and the exact shape of core::adj (raw ADJ JSON -> these types).
…n start_ntp_server function
… it can be used in new tests. Added comments and changed implementation of protection ID asignation and bit mapping. Created two tests as requested (review this as Gemini was used)
…ted Decoding of data.
… measurement in data.rs decoding data function.
…r (due to IO error)
…protections and datapackets
Backend/protocol javier ribal
Backend/protocol Completed protocol module for new Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.