Skip to content

feat(ui): add the 104px avatar, group and presence sizes - #189

Draft
renefloor wants to merge 3 commits into
mainfrom
feat/large-avatar-size
Draft

renefloor wants to merge 3 commits into
mainfrom
feat/large-avatar-size

Conversation

@renefloor

@renefloor renefloor commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Submit a pull request

Linear: FLU-797

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

The ringing call screens in stream-video-flutter are built on a 104px avatar, which no size named. This adds xxxl to StreamAvatarSize, StreamAvatarGroupSize and the presence/badge sizes that track them.

StreamAvatarGroup packs its children at 64px at that size — a diameter that sits between two named sizes — so the avatar gains an internal dimension override: the diameter comes from the group, while text, icon and border metrics keep coming from the size.

Tested by a widget test over StreamAvatarGroup at the new size.

Downstream

Adding a size is source-breaking for packages whose switches over these enums are exhaustive:

Screenshots / Videos

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

renefloor and others added 2 commits September 18, 2026 14:25
The ringing call screens are built on a 104px avatar, which no size named.
StreamAvatarGroup packs its children at 64px there — a diameter that sits
between two named sizes — so the avatar gains an internal override that
takes the diameter from the group while text, icon and border metrics keep
coming from the size.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@renefloor
renefloor force-pushed the feat/large-avatar-size branch from 6fead66 to e5cb621 Compare September 18, 2026 12:37
The gallery's usage and pixel-size tables switch exhaustively over the size
enums, so adding a size stops it analyzing until the size has a row.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.22%. Comparing base (04e0d1c) to head (6674525).

Files with missing lines Patch % Lines
...nts/avatar/internal/avatar_dimension_override.dart 66.66% 2 Missing ⚠️
.../src/components/badge/stream_online_indicator.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   69.18%   69.22%   +0.04%     
==========================================
  Files         214      215       +1     
  Lines        8845     8863      +18     
==========================================
+ Hits         6119     6135      +16     
- Misses       2726     2728       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant