Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The ringing call screens are built on a 104px avatar, which no size named. StreamAvatarGroup packs its children at 64px there — a diameter that sits between two named sizes — so the avatar gains an internal override that takes the diameter from the group while text, icon and border metrics keep coming from the size. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
renefloor
force-pushed
the
feat/large-avatar-size
branch
from
September 18, 2026 12:37
6fead66 to
e5cb621
Compare
The gallery's usage and pixel-size tables switch exhaustively over the size enums, so adding a size stops it analyzing until the size has a row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 69.18% 69.22% +0.04%
==========================================
Files 214 215 +1
Lines 8845 8863 +18
==========================================
+ Hits 6119 6135 +16
- Misses 2726 2728 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Linear: FLU-797
Github Issue: #
CLA
Description of the pull request
The ringing call screens in stream-video-flutter are built on a 104px avatar, which no size named. This adds
xxxltoStreamAvatarSize,StreamAvatarGroupSizeand the presence/badge sizes that track them.StreamAvatarGrouppacks its children at 64px at that size — a diameter that sits between two named sizes — so the avatar gains an internal dimension override: the diameter comes from the group, while text, icon and border metrics keep coming from the size.Tested by a widget test over
StreamAvatarGroupat the new size.Downstream
Adding a size is source-breaking for packages whose switches over these enums are exhaustive:
Screenshots / Videos
🤖 Generated with Claude Code