Conversation
Three switches over StreamAvatarSize and StreamAvatarGroupSize were exhaustive, so adding a size to stream_core_flutter stopped this package compiling — which is what StreamAvatarSize.xxxl (104px) did. They fall back to the largest size they know instead, and xxxl is mapped explicitly alongside the rest. Losing exhaustiveness loses the compiler's nudge that a new size needs placing, so a test takes it over: it walks the enum's values against the expected mapping and fails on one the table has no entry for. This package resolves stream_core_flutter fresh on every CI run, so that lands as a red test rather than as an avatar quietly drawn at the wrong size. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xsahil03x
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Linear: FLU-797
Github Issue: #
CLA
Description of the pull request
Three switches over
StreamAvatarSizeandStreamAvatarGroupSizewere exhaustive, so adding a size tostream_core_flutterstopped this package compiling — which is whatStreamAvatarSize.xxxl(104px) did, in GetStream/stream-core-flutter#189. They fall back to the largest size they know instead, andxxxlis mapped explicitly alongside the rest.Losing exhaustiveness loses the compiler's nudge that a new size needs placing, so a test takes it over: it walks the enum's values against the expected mapping and fails on one the table has no entry for. This package resolves
stream_core_flutterfresh on every CI run, so that lands as a red test rather than as an avatar quietly drawn at the wrong size.Screenshots / Videos
🤖 Generated with Claude Code