Skip to content

fix(ui): keep compiling when the design system adds an avatar size - #2974

Draft
renefloor wants to merge 1 commit into
masterfrom
fix/avatar-xxxl-size
Draft

renefloor wants to merge 1 commit into
masterfrom
fix/avatar-xxxl-size

Conversation

@renefloor

@renefloor renefloor commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Submit a pull request

Linear: FLU-797

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Three switches over StreamAvatarSize and StreamAvatarGroupSize were exhaustive, so adding a size to stream_core_flutter stopped this package compiling — which is what StreamAvatarSize.xxxl (104px) did, in GetStream/stream-core-flutter#189. They fall back to the largest size they know instead, and xxxl is mapped explicitly alongside the rest.

Losing exhaustiveness loses the compiler's nudge that a new size needs placing, so a test takes it over: it walks the enum's values against the expected mapping and fails on one the table has no entry for. This package resolves stream_core_flutter fresh on every CI run, so that lands as a red test rather than as an avatar quietly drawn at the wrong size.

Screenshots / Videos

🤖 Generated with Claude Code

Three switches over StreamAvatarSize and StreamAvatarGroupSize were
exhaustive, so adding a size to stream_core_flutter stopped this package
compiling — which is what StreamAvatarSize.xxxl (104px) did. They fall back
to the largest size they know instead, and xxxl is mapped explicitly
alongside the rest.

Losing exhaustiveness loses the compiler's nudge that a new size needs
placing, so a test takes it over: it walks the enum's values against the
expected mapping and fails on one the table has no entry for. This package
resolves stream_core_flutter fresh on every CI run, so that lands as a red
test rather than as an avatar quietly drawn at the wrong size.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants