Repository navigation
Judge from the probe output and write the qualification record - #95
Merged
Merged
Conversation
…st at rate and quantum (#94)
…utput it judged (#94)
…ostd-probe measures every CLAP plugin (#94) Since the judge measures through the probe runner, an installed plugin-qualify with no plugin-hostd answers 'cannot run the probe runner' and reads not-measured: the Install and qualify jobs went red on exactly that (rt-safe.clap exited 2). The RPM requires plugin-hostd >= 0.4.0, the DEB depends on plugin-hostd (>= 0.4.0~), the first release that ships the runner; README and the LV2 note say so.
linuxnow
force-pushed
the
feat/probe-output-reader-94
branch
from
October 18, 2026 17:02
34101ab to
08da748
Compare
… runs gave a probe output (#94) A target measured under two offers whose second run failed read not-measured in the table, but its first run stayed in runs and documents, so --out wrote a record for it and --pins pinned it. The runs of one target are now collected apart and appended only after the last one succeeds, as the old CLAP pass did. Test: the same plugin in two files, the first file's second run exits 2: runs and documents hold only the second file's two; red without the change (three runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
What: plugin-qualify now judges from plugin-hostd's probe output and writes the qualification record.
readProbeOutputrefuses a major it does not know (probe.format.major-unknown), a document carrying a verdict, and a document whosecstatesLimited/meetsProtocoldisagree withcpuidle[], the governor andunmet[](probe.format.derived-mismatch). Plugin-hostd's three example documents are infixtures/probe-output/.cpuCost.perRateQuantum); only the old per-rate format still reads per rate. A pair the grid lacks ishosting.cost.unmeasured-at-rate-and-quantum.rtSafetyDocument's; LV2 is judged on the interposer counts. Cost reasons sit beside the verdict at each profile's rate and quantum.OMX_PROBE_RUNNER, defaultplugin-hostd-probe), which keeps the deadline; no timeout of ours wraps it. The "not wired for LV2" refusal is gone.--outwrites the record and a byte copy of the probe output, named in the record with its SHA-256.plugin-qualify judge [--host-profile ..] [--qualification-dir ..] <probe-output>...for outputs already written.Not done, and why (also on the issue): the scan's
omx-clap-scantimeout stays (stage 5);lv2-measure.mjsstays until the runner has an LV2 child (plugin-hostd#76);--allstill refuses when LV2 bundles are on the path (no LV2 enumeration); the descriptor fingerprint is not in the record yet. The runner ships in plugin-hostd 0.4.0 (CLAP only; the LV2 child, plugin-hostd#76, is on its main and in no release yet). The RPM and DEB now require plugin-hostd >= 0.4.0, so the installed package findsplugin-hostd-probe; the unit tests' live CLI cases still use a stand-in (src/fake-probe-runner.support.mjs) that runs the real prober. The build job now installs plugin-hostd 0.4.0 from the channel, so a CLI test through the real runner is possible; that is #101, not this PR.How to verify:
pnpm install && make -C native deps all && pnpm lint && pnpm test. The proof issrc/probe-judge.test.ts: verdicts from probe outputs equal verdicts from today's documents for 20 line/profile cases, and two quanta of different cost give two different cost reasons. Each guard was broken, seen red and restored.