Repository navigation
Release 0.11.0 - #103
Merged
Merged
Release 0.11.0#103
Conversation
…st at rate and quantum (#94)
…utput it judged (#94)
…ostd-probe measures every CLAP plugin (#94) Since the judge measures through the probe runner, an installed plugin-qualify with no plugin-hostd answers 'cannot run the probe runner' and reads not-measured: the Install and qualify jobs went red on exactly that (rt-safe.clap exited 2). The RPM requires plugin-hostd >= 0.4.0, the DEB depends on plugin-hostd (>= 0.4.0~), the first release that ships the runner; README and the LV2 note say so.
The spec's BuildRequires, debian/control and the version make deps fetches. Paired with the commit that switches the LV2 measurer's dB readings to omx-dsp's omx_lin_to_db_d and the one after it for the host probe.
The six 20.0 * log10(...) of the measurer (the soak's silent-window test and its four readings, the sweep's rms_out) become omx_lin_to_db_d(x, 0.0), the library's 20.0 * log10(lin > floor ? lin : floor), inside the same > 0 guards, so nothing the guard rejects reaches it. The Makefile gives the measurer omx-dsp's include path (installed, else the headers make deps fetches). Paired with the floor commit before it.
20.0 * log10(mag < 1e-12 ? 1e-12 : mag) is omx_lin_to_db_d(mag, 1e-12), bit for bit for every finite magnitude (20 million drawn magnitudes plus the floor's neighbours, 0 differing bit patterns). A NaN magnitude is the one case that differs: it would read the floor, -240 dB; the next commit keeps it NaN. The line-67 pow(10, x / 20) stays: the library has no double-precision twin. The probe's build gets omx-dsp's and omx-contract's include paths.
…e -240 dB floor (#87) Handed to omx_lin_to_db_d, a NaN magnitude reads as the floor: silence, and silence passes 'the engaged plugin is measurably quieter' whenever the positive control still counts enough changed samples. level_db_at returns a NaN magnitude as it is, the finite path untouched, and a new claim says every level measured is a number. Checked over level_db_at: a sine window with one NaN sample reads NaN; at the commit before it read -240.000000.
…med line (#87) The grep proof #87 asks for, as a test: every log10/powf(10, ...) call in native/*.c fails unless it is allowlisted with its reason, and an allowlisted line that is gone fails too. The one entry is lv2-host-probe.c's pow(10.0, HOT_EXCESS_DB / 20.0): omx-dsp has omx_db_to_lin in float only, which is not bit-identical. A positive control shows the pattern sees both forms and skips a comment. Red with lv2-measure.c from before the omx_lin_to_db_d commit (two hits), red with the pow line rewritten (stale entry).
… runs gave a probe output (#94) A target measured under two offers whose second run failed read not-measured in the table, but its first run stayed in runs and documents, so --out wrote a record for it and --pins pinned it. The runs of one target are now collected apart and appended only after the last one succeeds, as the old CLAP pass did. Test: the same plugin in two files, the first file's second run exits 2: runs and documents hold only the second file's two; red without the change (three runs).
…cord # Conflicts: # src/clap-qualify.test.ts
Closed
…utput Since plugin-qualify judges from the probe output, --out writes <id>@<version>-<sha>.<offer>.qualification.json and, beside it, the .probe.json it judged, and no .rt-safety.json any more. The installed-package check now asks for a record and the probe output beside each one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One branch for the 0.11.0 release: the open pull requests merged by their head commits, then the version commit.
Merged:
Version 0.11.0 in package.json, packaging/plugin-qualify.spec and debian/changelog.
Run locally: pnpm lint, pnpm test (550 passed, 3 skipped), pnpm check:generated, pnpm test:py (177 passed, 7 skipped), private-refs check, make -C native deps all against omx-dsp 0.23.0. The asan build was not run here: this host has no libasan.