Repository navigation
Fix CI compatibility with NumPy 2.5.3 - #1451
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted replacement preserves warning filtering behavior, and no blocking issues remain.
Review effort: Balanced
Findings: None
What changed in this PR
Restores rocket landing test compatibility with NumPy 2.5.3 without changing the simulation or CI warning policy.
Changes:
- Upgrades NumPy from 2.3.5 to 2.5.3.
- Replaces the deprecated warning helper with standard-library filters for the same two solver warnings.
| File | Description |
|---|---|
| tests/test_rocket_powered_landing.py | Replaces warning suppression while preserving test-local scope. |
| requirements/requirements.txt | Pins NumPy to 2.5.3. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AtsushiSakai
marked this pull request as ready for review
October 4, 2026 21:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5.3 makes the rocket landing test fail under the existing
-Werrorsetting becausenumpy.testing.suppress_warningswas deprecated in NumPy 2.4. This is the failure seen in the Linux, macOS, and Windows checks on #1431.Upgrade NumPy from 2.3.5 to 2.5.3 and replace that helper with
warnings.catch_warnings()and message-specificwarnings.filterwarnings(). The same two known solver warnings remain filtered within the test; the CI warning policy and simulation are unchanged.Validation on Python 3.13.2 with NumPy 2.5.3 and the pinned requirements:
pytest tests/test_rocket_powered_landing.py -q -Werror: 1 passed after the fix.bash runtests.sh: 156 passed, including Ruff and mypy checks.python -m pip check: no broken requirements.git diff --check: passed.