Repository navigation
fix(dashboard): 按代码评审修工作台 —— 步骤条不漏隐藏字段的人名 · 超时结论认对 · 数字用全量(#202) - #204
Merged
Merged
Conversation
审批插件(query_service) - 我发起的「后面的步骤」先过 `_mask_forecast`:审批人取自发起人看不到的人员字段时只给节点名(原来写出人名,绕过字段遮罩) - 「最后一步」认引擎实际记的 `timeout_approve` / `timeout_reject`(原来写的是不存在的 `auto_approve`,超时驳回显示成上一个人的同意) - 步骤条里退回的那一步是 `sent_back`,不是绿勾 - `sort=attention` 超过 500 条时留加急的 + 最老的;`total` 单独 count;另给 `urgent_total` / `returned_total`(新增可选字段) - 转交来源取最近一条 transfer / reassign 记录(A→B→C 时 C 看到 B),新增 `transfer_kind` 区分转交和改派 - 待办行按快照缓存节点索引(`timeout_of` / `due_time` 收 `nodes`),不再每行遍历两遍整棵树 系统运行(dashboard_service) - 权限判据改用 `rbac.user_has_perm`(白名单 / casbin 模式下和接口守卫一致) - 被删应用下的 Webhook 端点不再提醒 - 登录失败突增的「今天」按查看人时区切(`attention?tz=`),条目带 `day` - 失败任务的最后一行报错一条窗口函数查完(原来 N+1) 前端 - 大标题加急数 / 分段的数用后端全量数;「最后一步」那句话、需要你留意的按钮挪进 `card-rules.ts` 并单测 - 「看记录」任务名为空时不带 `name`;「X 改派给你」;步骤条退回样式 - 常用入口编辑器:勾着的按整份可见清单算,超过 12 个时提示并允许取消 测试:后端新增 9 条(workflow 7 · admin 4,含改写的 2 条)· 前端单测 7 条;变异 18 个各自当场红。 工作台两份后端测试在 PG 16 / SQL Server 2022 / MySQL 8.4 私有库上全绿;后端全量 1487 通过; E2E dashboard-personalize / notice-reach / workflow 31 条通过。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么、为什么
#203 合并前跑的独立代码评审(
code-review high)报了 10 条 + 2 条存疑,按约定合并部署后另开这个 PR 修。masked,工作台照样写人名)_mask_forecast,遮住的只给节点名auto_approvetimeout_approve/timeout_reject(及 AI / 取不到人),没有办理人时说「超时自动同意 / 驳回」sent_back状态,前端用退回图标sort=attention超过 500 条丢的是最老的那批,total封顶 500total单独 counturgent_total/returned_total,前端用全量数attention收tz,和visits同一种切法transfer_kinduser_has_perm不一致user_has_permname=null,执行记录页校验不过整页报错新增字段都是可选的(1.0 兼容约定:
/api/v1/*只加字段)。前端纯逻辑挪进dashboard/card-rules.ts便于单测。自查清单
pnpm typecheck --force/pnpm lint/pnpm build/pnpm i18n:check && pnpm i18n:jsx/pnpm ctx:check/pnpm arch:check/pnpm test:js过没有 E2E 的:步骤条的退回样式、「X 改派给你」、常用入口超过 12 个时的提示(后端行为和纯逻辑有测试)。
关联 issue
#202
🤖 Generated with Claude Code