Repository navigation
[ci] Frail attempt to fix riscv qemu run - #1411
Merged
Merged
Conversation
serge-sans-paille
force-pushed
the
ci/riscv-qemu
branch
5 times, most recently
from
September 10, 2026 09:02
6ffd40e to
c15cdfa
Compare
This seems to be gcc specific as clang works nice, even if not perfect, it also removes some duplicate CI configuration and it restores the build to green, so I think it's a decent trade off.
serge-sans-paille
force-pushed
the
ci/riscv-qemu
branch
from
September 10, 2026 09:10
c15cdfa to
4b2a146
Compare
Contributor
Author
|
@DiamonDinoia as the author of 8b81687, can you review this patch? Thanks! |
DiamonDinoia
approved these changes
Sep 10, 2026
DiamonDinoia
left a comment
DiamonDinoia
left a comment
Contributor
There was a problem hiding this comment.
LGTM, less code is better. It seems gcc emits an instruction that kills qemu? While clang does no?
Interesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.