Repository navigation
fix(previews): resolve Plugin Check errors in the shipped plugin - #838
Open
josephfusco wants to merge 4 commits into
Open
josephfusco wants to merge 4 commits into
josephfusco wants to merge 4 commits into
Conversation
The plugin header said "8.2+", which Plugin Check rejects, and readme.txt still said PHP 7.4 from before 1.0.2 raised the minimum to 8.2. readme.txt also said Tested up to 6.9 while the plugin header said 7.0; both now say 7.0.
|
Contributor
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (31)📁 examples/hwp-preview-rest/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-rest/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-rest/.wp-env.json (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/__MACOSX/._uploads (1 error)
📁 examples/hwp-preview-wpgraphql/.wp-env.json (1 error)
📁 examples/hwp-preview-astro/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-astro/.wp-env.json (1 error)
📁 .env.dist (2 errors)
📁 docs/.gitkeep (1 error)
📁 .docker/.env.ci (1 error)
📁 .editorconfig (1 error)
📁 .wp-env.json (1 error)
📁 phpstan.neon.dist (1 error)
📁 bin/build-docker.sh (1 error)
📁 bin/_lib.sh (1 error)
📁 bin/sync-package-version.sh (1 error)
📁 bin/run-codeception.sh (1 error)
📁 bin/install-plugins.sh (1 error)
📁 bin/install-test-env.sh (1 error)
📁 bin/local/run-e2e-tests.sh (1 error)
📁 bin/local/setup-docker-env.sh (1 error)
📁 bin/local/run-qa.sh (1 error)
📁 bin/local/run-unit-tests.sh (1 error)
📁 .docker/init-docker.sh (1 error)
📁 examples/hwp-preview-wpgraphql/example-app/src/pages/[identifier].js (1 error)
📁 examples/hwp-preview-astro/example-app/src/pages/[...uri].astro (1 error)
📁 hwp-previews.php (1 error)
📁 readme.txt (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
…ix runs The codeception matrix tests WordPress 6.7 through 6.9, so claiming 7.0 overstated what's tested.
The plugin header said GPLv2 or later, but readme.txt and composer.json said GPL-2.0, which reads as GPL-2.0-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the real errors Plugin Check reports for the hwp-previews zip. One commit per fix:
Requires PHP: 8.2+→8.2in the plugin header, because Plugin Check only accepts a plain version.readme.txtsaid PHP 7.4, from before 1.0.2 raised the minimum to 8.2, and now says 8.2.readme.txt. 6.9 is the newest WordPress version the CI matrix tests.readme.txtandcomposer.jsonsaidGPL-2.0, which reads as GPL-2.0-only, while the header said "GPLv2 or later". All three now say GPL-2.0-or-later.ABSPATHguards inactivation.php,deactivation.php, and theadmin.phpandiframe.phptemplates. Each guard goes after the file docblock, matching the existing pattern.Testing
composer archiveand ranwp plugin check hwp-previewslocally in wp-env, using the same options as the workflow in ci: run Plugin Check on the built plugin archive #830. The only error left is "Tested up to: 6.9 < 7.1", which stays until WordPress 7.x is added to the matrix.php -landphpcspass.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with running Plugin Check locally and fixing the errors it reported.