Skip to content

Sign the Phar with SHA-512 instead of SHA-256 #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Oct 5, 2026
Merged

Sign the Phar with SHA-512 instead of SHA-256 #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions features/make-phar.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,14 @@ Feature: Check `utils/make-phar.php` output
Error: Couldn't find plugin-status.mustache
"""
And the return code should be 0

Scenario: Phar is signed with SHA-512
Given an empty directory
And a new Phar with the same version

When I run `cp {PHAR_PATH} signed.phar`
And I run `php -r 'echo (new Phar( "signed.phar" ))->getSignature()["hash_type"];'`
Comment thread
swissspidy marked this conversation as resolved.
Then STDOUT should be:
"""
SHA-512
"""
4 changes: 4 additions & 0 deletions utils/make-phar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,10 @@ function get_composer_versions( $current_version ) {
EOB
);

// PHP verifies the signature over the whole archive on every invocation, and
// SHA-512 is noticeably faster to compute than the SHA-256 default on 64-bit CPUs.
$phar->setSignatureAlgorithm( Phar::SHA512 );

$phar->stopBuffering();

chmod( DEST_PATH, 0755 ); // Make executable.
Expand Down
Loading