Skip to content

Use cached plugin and theme installs in tests - #353

Merged
schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs
Nov 2, 2026
Merged

schlessera merged 1 commit into
mainfrom
measure/cached-extension-installs

Conversation

@schlessera

@schlessera schlessera commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Switches the feature files to the these installed plugins: / these installed themes: steps from wp-cli/wp-cli-tests#404, and requires wp-cli/wp-cli-tests ^5.4.0.

Measured on this test suite: Behat time -1.8% (255.0 → 250.3 job minutes, summed over the matrix). Details in wp-cli/wp-cli-tests#404.

Summary by CodeRabbit

  • Chores
    • Updated the development test tooling requirement.
    • Updated core update and database update test scenarios to start with the Twenty Twenty theme installed and active. These scenarios retain their existing update steps and expectations.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d66fbf39-1d14-4c60-b447-a80a99c7ddc0
Commits

Reviewing files that changed from the base of the PR and between 5fd1f9b and d58dcdd.

Files selected for processing: 5
  • composer.json
  • features/core-check-update-db.feature
  • features/core-check-update.feature
  • features/core-update-db.feature
  • features/core-update.feature

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Update-related feature scenarios now declare twentytwenty installed and active through fixtures instead of invoking theme installation. composer.json raises the minimum compatible wp-cli/wp-cli-tests version from ^5 to ^5.4.0.

Changes: Update scenarios

Layer / File(s) Summary
Test dependency and theme fixtures
composer.json, features/core-check-update*.feature, features/core-update*.feature
The development dependency constraint changes to ^5.4.0. Update-check, core-update, and database-update scenarios declare twentytwenty installed and active through fixtures instead of running the theme-install command.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: swissspidy, ernilambar

Merge Risk: Minimal · up to d58dc

No merge-blocking issue is identified in the test-fixture migration or dependency update. Merge after normal checks pass.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: using cached plugin and theme installations in tests.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added command:core Related to 'core' command scope:testing Related to testing labels Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@schlessera
schlessera force-pushed the measure/cached-extension-installs branch from e4c80e4 to d58dcdd Compare November 2, 2026 02:56
@schlessera schlessera changed the title [DO NOT MERGE] Test wp-cli/wp-cli-tests#404 Use cached plugin and theme installs in tests Nov 2, 2026
@schlessera
schlessera marked this pull request as ready for review November 2, 2026 02:56
@schlessera
schlessera requested a review from a team as a code owner November 2, 2026 02:56
@schlessera
schlessera merged commit e8a7876 into main Nov 2, 2026
52 checks passed
@schlessera
schlessera deleted the measure/cached-extension-installs branch November 2, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:core Related to 'core' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant