Repository navigation
Fix PHPStan errors - #348
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe config conversion flow now checks that a wp-config.php path is available before checking writability or modifying the file. Changeswp-config path guard
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to When 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Fixes the newly reported PHPStan errors from the scheduled code quality run (https://github.com/wp-cli/core-command/actions/runs/37563662550):
Utils\locate_wp_config()returnsfalsewhen nowp-config.phpis found. This PR guards against that case:multisite_convert, the constants are written only if a config path was found. Otherwise the existing "could not be written" warning is shown.modify_wp_config()returnsfalseearly when there is no config path.🤖 Generated with Claude Code
https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
Generated by Claude Code
Summary by CodeRabbit
wp-config.phpcannot be located without attempting to check whether the missing file is writable. Existing configuration updates are unchanged when the file is available.