Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new check triggers ShellCheck violations and leaves check numbering inconsistent.
2 open findings
What changed in this PR
Adds a source check ensuring WOLFSSL_CACHE_VERSION increases by no more than one from the previous release tag.
Changes:
- Compares current and tagged cache versions.
- Reports excessive version bumps.
| File | Summary |
|---|---|
.github/scripts/check-source-text.sh |
Adds the cache-version sanity check and invokes it. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Retest this please. (network timeout or something) |
Comment on lines
+301
to
+302
| release_tag=$(git describe --tags --abbrev=0 --match 'v*-stable' \ | ||
| 2>/dev/null) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WOLFSSL_CACHE_VERSIONis incremented when backwards compat changes are made to persistent session cache logic.The intention was only one bump per release, max.
However, overeager review bots will request a ver bump on every cache change.
Add a source sanity check clamping it to
<= +1from the prior release tag.Testing
sed -i '/#define WOLFSSL_CACHE_VERSION/s/[0-9]\+/5/' wolfssl/ssl_sess.h .github/scripts/check-source-text.shgives:
error: WOLFSSL_CACHE_VERSION: bumped too many times: got 5, expected <= 4 ::error::check-source-text found violations