Repository navigation
Harden the PID file, login shell and port parsing - #1326
Open
ejohnstown wants to merge 4 commits into
Open
ejohnstown wants to merge 4 commits into
ejohnstown wants to merge 4 commits into
Conversation
Where open() cannot refuse a final-component symlink, no pre-check can stop a link swapped in before the open, and the fstat gate accepts a root-owned target. wolfSSHD_ConfigSavePID now writes no PID file there instead of relying on a racy lstat. - test_ConfigSavePID gets a variant for that build that expects no file Issue: F-14764
SHELL_Subsystem copied pw_shell into an 80-byte buffer before execv(), so a longer path ran whatever its first 79 bytes named. The child now passes pw_shell to execv() directly, and builds the login argv[0] from its basename so a long path no longer falls back to "-sh". - add sshd_long_shell_test.sh, which logs in as a throwaway user whose shell path is longer than 80 bytes and checks the shell's $0 Issue: F-14757
It was the one channel sender that read ssh->defaultPeerChannelId without a NULL check. It now returns WS_BAD_ARGUMENT for a NULL ssh and logs entry and exit like its siblings. - add TestTerminalResizeNullSsh to regress.test Issue: F-14769
The -p option of wolfssh, client, wolfscp, wolfsftp and echoserver now goes through a strtol check, so a value that is not wholly a number in range exits with an error instead of wrapping into a different port. - apps/wolfssh: ClientParsePort(), shared with ClientParseDestination(), which also rejects an empty "ssh://host:" port instead of defaulting - examples: a ClientParsePort() in examples/client/common.c; port 0 is rejected in every build, not only with a main driver - echoserver: accepts 0 to 65535, keeping 0 for the test harness - add TestClientParsePort and an empty URI port case to regress.test Issue: F-14763, F-14767, F-14768, F-12552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four hardening fixes from an outside audit: the wolfsshd PID file and login shell, a missing NULL check, and port parsing in the client tools.