Skip to content

Fix ML-DSA composite macros - #1259

Merged
ejohnstown merged 1 commit into
wolfSSL:masterfrom
stenslae:fix-composites
Sep 21, 2026
Merged

ejohnstown merged 1 commit into
wolfSSL:masterfrom
stenslae:fix-composites

Conversation

@stenslae

Copy link
Copy Markdown
Member

Added per-composite gate macros to group in dependencies, and fixes to the ED448 composite and ED25519 macros. Updated macro call sites to use the new, single macros. Added CI workflow to exercise composite configurations.

@stenslae stenslae self-assigned this Sep 16, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1259

⚠️ An internal error occurred during the automated review. This error has been logged. Please contact the Fenrir team if you need assistance.

Error: RuntimeError

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1259

⚠️ An internal error occurred during the automated review. This error has been logged. Please contact the Fenrir team if you need assistance.

Error: RuntimeError

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1259

⚠️ An internal error occurred during the automated review. This error has been logged. Please contact the Fenrir team if you need assistance.

Error: RuntimeError

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1259

Scan targets checked: wolfssh-src, wolfssh-bugs

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Sep 16, 2026
Comment thread src/internal.c
Comment thread .github/workflows/mldsa-composite-config.yml
Comment thread tests/unit.c

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #1259

Scan targets checked: wolfssh-src, wolfssh-bugs

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Comment thread wolfssh/internal.h
@ejohnstown
ejohnstown dismissed wolfSSL-Fenrir-bot’s stale review September 21, 2026 18:11

Dismissing false positive.

@ejohnstown
ejohnstown merged commit 3bec025 into wolfSSL:master Sep 21, 2026
217 of 219 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants