Repository navigation
r-2112: sign in with webshare login - #2
Merged
Merged
Conversation
othercodes
requested review from
frgtn,
gmunguia,
laureenas,
meznaric and
tehnuty
September 28, 2026 16:34
othercodes
force-pushed
the
feat/r-2112-oauth-login
branch
from
September 28, 2026 16:41
063e6e1 to
312b8f3
Compare
othercodes
force-pushed
the
feat/r-2112-oauth-login
branch
from
September 28, 2026 16:54
312b8f3 to
d0ca47f
Compare
meznaric
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webshare loginopens the browser, runs the authorization code flow with PKCE against a loopback redirect (RFC 8252), and stores the token in the OS keychain, falling back to a file only the owner can read.webshare logoutrevokes the refresh token and then the access token before forgetting them; forgetting alone leaves a token the API still answers.whoaminow says which credential it used.WEBSHARE_API_KEYkeeps working and takes precedence, so scripts and CI are untouched.Notes on the parts worth a second look:
/.well-known/oauth-authorization-server, so nothing is hard-coded and--base-urlalone points the login at a test environment. The token and revocation endpoints are stored with the credentials, so an ordinary command never fetches metadata just to refresh.issmatching the server (RFC 9207). Any local process can reach that port, so this is what keeps it ours.loginasks for the seven scopes the CLI's own commands need and nothing else.--scopeoverrides.golang.org/x/oauth2is pinned to v0.30.0 rather than v0.37.0: the newer one requires Go 1.26 and CI tests 1.23 and 1.24.Not in here: the device authorization grant.
loginneeds a browser on the same machine, so over SSH or in a containerWEBSHARE_API_KEYis still the way in. The server does not offer that grant today either.