Repository navigation
Conversation
webern
added
feature
6 tasks done
webern
changed the title
webern
marked this pull request as ready for review
October 30, 2026 08:03
<notehead> has parentheses and color attributes that mx::api could not hold. A parenthesized notehead (the usual ghost-note mark) lost its parentheses, a colored one lost its color, and on a normal notehead the whole element disappeared. NoteData gains noteheadParentheses (a Bool) and noteheadColor (an optional ColorData). The reader fills them, and the writer emits <notehead> for a normal notehead whenever either is set. The defaults leave output unchanged. lysuite/ly22d_Parenthesized_Noteheads.xml and musuite/testNoteheads.xml now round-trip and are pinned in the baseline.
webern
force-pushed
the
m/mxdev-nhparen
branch
from
October 30, 2026 08:15
f867658 to
19232cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<notehead>lost itsparenthesesandcolorattributes, and on a normal notehead the wholeelement vanished, because the writer only emitted
<notehead>normal</notehead>whenfilledor aSMuFL glyph was set.
NoteDatagains two fields next tonoteheadFilledandnoteheadSmufl:Bool noteheadParentheses(unspecified writes nothing; yes/no are written as given)std::optional<ColorData> noteheadColor(empty means the notehead takes the note's color),following the newer optional-color precedent (
DampData,TempoData, ...)NoteWriter::setNoteheadstill skips the element when nothing is set, and now writes a normalnotehead when either new field is set. Additive; plain fields rather than a notehead struct,
because grouping would break the released
noteheadFilledandnoteheadSmufl.data/api.features.xmlmarks noteheadparenthesesas supported, and correctsfilledfrompartial to yes (stale since
noteheadFilledwas added).Two corpus files now round-trip and are pinned:
Still not modeled: notehead font attributes (which keep
synthetic/notehead.*failing), and anexplicit
<notehead>normal</notehead>with no attributes is still dropped (ly22a).Testing
NoteDataTestcases for parentheses yes/no (includingparentheses="no"on a normalnotehead), color on normal and non-normal noteheads, and equality; default and synthetic-file
tests extended
make api-testpasses (6300 assertions in 740 test cases)make api-roundtrippasses, 454 of 454 pinned filesmake api-roundtrip-discover: 454 pass, against 452 on the commit below; no file lost its passmake fmt-checkpassesReferences
mx::api)