Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree to the Weaviate Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom embedded archive URLs leave
_parsed_weaviate_versionempty, so distinct URLs share the same binary-cache filename. After downloading build A, requesting build B with the same cache directory silently selects A without downloading B.Change
Use the download URL as the hash input only when no version was parsed. Explicit versions, official GitHub release URLs and resolved
latesttags keep their existing cache names, preserving #1681's advancing-latestbehavior. Old anonymous cache files are left untouched but no longer selected.Add 12 regression/compatibility cases using tiny ZIP/tar archives and mocked downloads. They check selected file bytes, repeat reuse, host/path differences, legacy-cache isolation and existing official caches. Six cases fail on unchanged upstream; all 12 pass with this fix. No public API or documentation change is needed.
Validation
twine checkpass.Live server, Docker/Pyodide and other Python/platform matrices were not run locally. The existing
authlib==1.6.12development pin conflicts with the runtime's>=1.7.1; validation used the runtime-compatible dependency without changing requirement files.AI assistance: Codex implementation/testing and independent Codex and Claude Opus code review.