Repository navigation
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch objects with
properties=Nonecurrently omit the entire protobuf properties message, including explicitly supplied references.DataObjectdefaults toproperties=None, so a reference-only object can be reported as inserted even though its links were never sent. This affects both synchronous and asynchronousinsert_manyand the shared batch encoder.For a collection with a
relatedreference property and an existing target UUID, this call drops the reference from the outgoing request:Serialize the properties message when references are supplied, using an empty ordinary-property mapping when necessary. Objects with neither properties nor references keep their existing wire representation.
Validation
test/suite passes 550 tests with 1 skipped.Validated on Python 3.12.12 / macOS arm64. A real Weaviate database, Docker integration suite and other platforms were not exercised. AI assistance was used for investigation, implementation and validation.