Repository navigation
fix(cli): reconcile Cloudflare Worker logging settings - #604
Draft
TheAlexLichter wants to merge 3 commits into
Draft
TheAlexLichter wants to merge 3 commits into
TheAlexLichter wants to merge 3 commits into
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-cloudflare-worker-settings-void-cloud.voidzero-docs.workers.dev (commit 6f33d56)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
TheAlexLichter
marked this pull request as ready for review
October 27, 2026 01:25
TheAlexLichter
marked this pull request as draft
October 27, 2026 01:34
Member
Author
|
The current revision narrows this PR to publishing explicit Logpush through the existing post-activation settings path and retaining it in the existing version snapshot. The broader settings operations and compensation framework have been removed. The net diff is nine files. Validation for head
Earlier review results refer to the superseded broader implementation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, an existing Worker with
logpush: falsecurrently fails withCloudflare Worker setting logpush cannot be uploaded with pinned secrets.Simply accepting the key would leave it unapplied.This PR resolves it.