Skip to content

fix(cli): reconcile Cloudflare Worker logging settings - #604

Draft
TheAlexLichter wants to merge 3 commits into
mainfrom
fix/cloudflare-worker-settings
Draft

TheAlexLichter wants to merge 3 commits into
mainfrom
fix/cloudflare-worker-settings

Conversation

@TheAlexLichter

@TheAlexLichter TheAlexLichter commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

At the moment, an existing Worker with logpush: false currently fails with Cloudflare Worker setting logpush cannot be uploaded with pinned secrets. Simply accepting the key would leave it unapplied.

This PR resolves it.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-cloudflare-worker-settings-void-cloud.voidzero-docs.workers.dev (commit 6f33d56)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://59c95686-void-cloud.voidzero-docs.workers.dev 6f33d56 2026-10-27T01:45:16.935Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://783a88cf-void-cloud.voidzero-docs.workers.dev d39cb9d 2026-10-27T01:21:08.496Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://1a4bcc4f-void-cloud.voidzero-docs.workers.dev ecb8200 2026-10-27T01:07:38.108Z Visit the dashboard ↗

@cpojer
cpojer requested a review from Brooooooklyn October 27, 2026 01:06
@TheAlexLichter
TheAlexLichter marked this pull request as ready for review October 27, 2026 01:25
@TheAlexLichter
TheAlexLichter marked this pull request as draft October 27, 2026 01:34
@TheAlexLichter

Copy link
Copy Markdown
Member Author

The current revision narrows this PR to publishing explicit Logpush through the existing post-activation settings path and retaining it in the existing version snapshot. The broader settings operations and compensation framework have been removed. The net diff is nine files.

Validation for head 6f33d56e69ec6d9fbf2a38658f5220cff8d3e75f:

  • 313 focused tests passed; affected verification passed 11,271 tests across 513 suites.
  • Full vp run test:all passed: 14,937 tests across 744 suites, 79/79 tasks including builds, formatting, lint, and typechecks. All GitHub checks passed, including npm and pnpm prepublish tests.
  • Mutation verification caught ten failures when Logpush support was removed independently from the version snapshot, settings publisher, pinned deployment transport, and operation process. Production sources were restored after each check.
  • CodeRabbit CLI: pass, zero findings, completed outcome, all nine changed files reviewed against base 879ddaa1213bdb599b2ec495adf20881844af637. Run through the budget helper, which validated the terminal event, exact head, and file coverage.

Earlier review results refer to the superseded broader implementation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant