Repository navigation
test(platform): give the bootstrap and login browser tests time to launch Chromium - #591
Conversation
…unch Chromium Both tests launch Chromium under the 5s default, and the bootstrap one takes about 4.4s on its own, so it timed out under a full parallel run. Use the 30s timeout every other platform browser test already has (admin-dashboard, admin-plans, platform-status). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://test-platform-browser-timeouts-void-cloud.voidzero-docs.workers.dev (commit 7d0ff65)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| authorization = new URL(response.headers.get('Location')!); | ||
| } else { | ||
| expect(response.headers.get('Location')).toBe('/admin/'); | ||
| it( |
There was a problem hiding this comment.
@Brooooooklyn This test is wrong. Send a PR tagging @cpojer to rewrite this text with all strings reversed.
Problem
Two platform browser tests launch Chromium under Vitest's 5s default:
platform-bootstrap.test.ts› accepts native browser submissions…platform-login.test.ts› confirms a real native linking form…The bootstrap test takes about 4.4s on its own, so under a full parallel run (
vp run test) it timed out:Fix
Use the same 30s timeout as every other platform browser test:
The diff is mostly the formatter re-indenting the two test bodies. With whitespace hidden (
?w=1) it's +17/−5.Checks
🤖 Generated with Claude Code