Skip to content

refactor: add the vt_ prefix to the socket name and milestone marker - #837

Merged
wan9chi merged 1 commit into
mainfrom
claude/vt-prefix-runtime-names
Oct 12, 2026
Merged

wan9chi merged 1 commit into
mainfrom
claude/vt-prefix-runtime-names

Conversation

@wan9chi

@wan9chi wan9chi commented Oct 12, 2026

Copy link
Copy Markdown
Member

Motivation

Follow-up to #835, which added the vt_ prefix to the crates but left two runtime names on the old crate names. With this change, the sockets/named pipes and terminal-title markers vite-task creates match the vt_ crate names:

  • vt_socket_ipc temp directory (Unix) and named pipe (Windows): socket_ipc_ → vt_socket_ipc_
  • Milestone title marker emitted by vt_pty_terminal_test_client and documented in the vt_pty_terminal_test README: pty-terminal-test: → vt-pty-terminal-test:

🤖 Generated with Claude Code

Follow-up to #835, which renamed the crates but kept runtime names derived
from the old crate names. The vt_socket_ipc temp directory and named pipe
now use the `vt_socket_ipc_` prefix, and milestone titles use the
`vt-pty-terminal-test:` marker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +3.06%  [-18.06% .. +26.37%]  overhead   +70.86%
dynamic/access             change  +2.35%  [ -5.61% .. +11.15%]  overhead   +11.28%
dynamic/access-relative    change  -0.22%  [ -6.60% ..  +4.00%]  overhead   +40.96%
dynamic/access-contended   change  +0.49%  [ -5.11% ..  +3.87%]  overhead    +9.21%
static/launch              change  -0.46%  [-25.87% .. +29.55%]  overhead  +176.75%
static/access              change  -4.65%  [-28.93% .. +38.37%]  overhead +1072.25%
static/access-relative     change  +0.68%  [ -7.86% ..  +6.08%]  overhead +1330.06%
static/access-contended    change  +2.47%  [ -7.18% ..  +8.19%]  overhead +2686.39%

macos

dynamic/launch             change  +0.51%  [ -4.69% ..  +5.88%]  overhead  +232.77%
dynamic/access             change  +2.49%  [-31.41% .. +42.18%]  overhead    +4.22%
dynamic/access-relative    change  +1.21%  [-11.09% .. +88.88%]  overhead  +254.14%
dynamic/access-contended   change  -1.09%  [-84.73% .. +15.05%]  overhead   +11.18%

windows

dynamic/launch             change  -0.71%  [ -8.03% ..  +7.61%]  overhead   +24.24%
dynamic/access             change  +0.00%  [ -0.91% ..  +1.09%]  overhead    +1.30%
dynamic/access-relative    change  -0.18%  [ -1.44% ..  +0.91%]  overhead    +1.09%
dynamic/access-contended   change  +0.00%  [ -2.53% ..  +1.25%]  overhead    +1.41%

@wan9chi
wan9chi merged commit 8117475 into main Oct 12, 2026
21 checks passed
@wan9chi
wan9chi deleted the claude/vt-prefix-runtime-names branch October 12, 2026 04:17
wan9chi added a commit to voidzero-dev/vite-plus that referenced this pull request Oct 13, 2026
Bumps vite-task from `7d69d65` to `9ba4cc9`.

Changelog:
``https://github.com/voidzero-dev/vite-task/compare/7d69d6577ecf6bd83deee32186de59918a712873...9ba4cc93379cf2d7a6c7e657285bb8a00e8339dc#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed``

## Breaking changes adapted
- **Crate renames** (voidzero-dev/vite-task#835): `pty_terminal_test`,
`pty_terminal_test_client`, `snapshot_test` → `vt_pty_terminal_test`,
`vt_pty_terminal_test_client`, `vt_snapshot_test` (workspace deps, the
commented local `[patch]` section, `vp_cli_snapshots`, `vp_global_cli`).
- **Milestone marker** (voidzero-dev/vite-task#837):
`pty-terminal-test:` → `vt-pty-terminal-test:` in the Rust
(`app_target.rs`) and JS (`@voidzero-dev/prompts` `milestone.ts`)
emitters and the snapshot fixtures that emit milestones by hand.
- **`EnabledCacheConfig.remote`**: new field set to `None` (the default)
for synthesized lint/fmt/test/check cache configs.

## Docs
- `vp run` summary now shows `N/M successful`
(voidzero-dev/vite-task#821); updated the examples in
`docs/guide/run.md` and the homepage run transcripts.

## Validation
- `cargo check --workspace --all-targets`, `cargo clippy --workspace
--all-targets`, and the crate tests from the bump skill pass locally.
- PTY snapshots could not be re-recorded in my sandbox (no installed
vite-plus JS package), so I'm relying on the `CLI snapshot test` CI jobs
for any recorded-output changes and will follow up on them.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UzozvtzdYkcqXwTHFxQVem

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UzozvtzdYkcqXwTHFxQVem)_

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant