Repository navigation
refactor(cli): replace glob with tinyglobby - #3099
Merged
Merged
Conversation
Shrinks the bundled CLI (glob pulled in path-scurry, lru-cache and minipass) and makes negated workspace patterns like `!packages/foo` exclude packages, matching pnpm. Paths from findPackageJsonFilesFromPatterns stay native.
liangmiQwQ
changed the title
glob with tinyglobby
liangmiQwQ
changed the title
glob with tinyglobbyglob with tinyglobby
liangmiQwQ
marked this pull request as ready for review
October 17, 2026 14:48
Member
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fengmk2
changed the title
glob with tinyglobbyglob with tinyglobby
fengmk2
approved these changes
Oct 17, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 821ed9e3ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tinyglobby matches patterns that don't end in `*` as `<pattern>/**` too, so a directory named like `ci.yml` pulled its contents into the setup-vp migration. Set `expandDirectories: false` to match the previous glob behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
globwithtinyglobbyinpackages/cli.globis bundled into the CLI and bringspath-scurry,lru-cacheandminipasswith it.tinyglobbyis smaller, andpackages/corealready uses it.globwas used in three places: workspace package discovery (utils/workspace.ts), finding.githubworkflow and action files duringvp migrate(migrator/setup.ts), and one test.User-visible behavior changes:
['packages/*', '!packages/foo']skipspackages/foo. (I'll treat it as a fix, because it actually maches pnpm's behavior).**patterns now follow symlinked directories, so workspace discovery andvp migratemay find additional packages or GitHub composite actions under those directories. (Also follow pnpm10 behavior)packages/abeforepackages/b. (IMO, that isn't a big deal).The
globcatalog entry stays becauserolldown/packages/rolldownstill uses it.Size
packages/cli/distJS, measured withbuild-tsbefore and after:editor-*.jsstaged/bin.jspicomatch-*.js(new)picomatchwas already bundled intostaged/bin.jsfor lint-staged.tinyglobbyuses it too, so it moved into a shared chunk instead of being bundled twice.🤖 Generated with Claude Code